1966284 - hide new profile manager pages (new, edit, delete) from about:about

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Daniel Veditz [:dveditz]]

The about:about page lists the profile management pages about:deleteprofile, about:editprofile, about:newprofile and it shouldn't -- I think we want people to get to those pages from the about:profilemanager entry point (especially "new" which is supposed to involve launching a whole new copy of Firefox). Certainly they shouldn't be shown in Release or Beta builds where the new profilemanager is disabled and the links do nothing but add to the clutter.

Ironically, about:profilemanager itself is hidden from about:about. That was done in bug 1884471 because at the time it was unfinished and because autocomplete preferred it over the about:profiles people were intending. In builds where it does work (e.g. Nightly) we do probably want this to be shown in about:about and to autocomplete ahead of the old confusing about:profiles (but we should still hide it in builds where it's disabled if that's possible). Better to have one about:about entrypoint than three.

The fix is easy: add nsIAboutModule::HIDE_FROM_ABOUTABOUT to their about-redirector entries
https://searchfox.org/mozilla-central/rev/25a38ac3b851b63e7d85a850940c354609e8126d/browser/components/about/AboutRedirector.cpp#164-178

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mossop, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mossop, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[mlucks]

Attachment: Bug 1966284 - Hide new profile manager pages from aboutabout - r?dveditz,kpatenio

Comment 4

[Daniel Veditz [:dveditz]]

Can this be landed this week so it doesn't persist into Firefox 144?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b503d9fba942
https://hg.mozilla.org/integration/autoland/rev/214a32f546e2
Hide new profile manager pages from aboutabout - r=dveditz,profiles-reviewers,mossop,jhirsch

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/214a32f546e2