Add auto-PR closer on GitHub
Categories
(Conduit :: moz-phab, enhancement)
Tracking
(Not tracked)
People
(Reporter: shtrom, Assigned: shtrom)
Details
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
[mozilla-conduit/review] Bug 1966288 - workflows: import pr-close from mozilla-firefox/firefox (#17)
49 bytes,
text/x-github-pull-request
|
Details | Review |
Now that we can land to the review repo with lando, we should disable the option to use PRs. We can use the same workflow as for the mf/f repo https://github.com/mozilla-firefox/firefox/blob/main/.github/workflows/close-pr.yml (note that some permissions may need to be set-up, too see bug 1966018)
We should also add rules to forbid direct pushes.
| Assignee | ||
Comment 1•1 year ago
•
|
||
:glob, what were the permissions required in https://bugzilla.mozilla.org/show_bug.cgi?id=1966018#c1?
edit: Was it Read and write permissions for Workflow permissions in https://github.com/mozilla-conduit/review/settings/actions, or something else/more?
| Assignee | ||
Comment 2•1 year ago
|
||
(Updating the name of the README file to suit.)
Updated•1 year ago
|
Actions need read-write; they get read-only by default.
Comment 4•1 year ago
|
||
Comment 5•1 year ago
|
||
Authored by https://github.com/shtrom
https://github.com/mozilla-conduit/review/commit/544f9199fd85bb1ca1a73b179523be9c224ca21c
[main] Bug 1966288 - workflows: import pr-close from mozilla-firefox/firefox (#17)
Description
•