1966384 - Improve Unified Search Button Interaction with Support for Option Selection via Mouseup

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Chris Bellini (:cbellini)]

Attachment: A sample interaction that shows the search option selection happening on mouseup

Improve Unified Search Button interaction by reducing clicks required to select a search option from it, supporting the following workflow:

1. Click on the Unified Search Button to expand its options, and continue to hold the mouse button down.
2. Hover over the desired search option, which highlights the option on hover.
3. Release the mouse button to select the option.

Comment 1

[Moritz Beier [:mbeier]]

Attachment: Bug 1966384 - Convert unified search button to a type=menu toolbarbutton to open popup natively. r?daisuke

This makes the popup open on mousedown so users can select a search engine with a single click. It also allows removing some of the custom event handling.
The other user-facing difference is that the down arrow doesn't open the popup anymore on Windows and Linux.
Since the popup is now rebuilt after opening instead of before, tests must now wait for a rebuild event.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a87238a3a0d3
https://hg.mozilla.org/integration/autoland/rev/36cc2982a9f1
Convert unified search button to a type=menu toolbarbutton to open popup natively. r=search-reviewers,urlbar-reviewers,daisuke

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/36cc2982a9f1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f37088d7c85c
https://hg.mozilla.org/integration/autoland/rev/48883c6bb883
Revert "Bug 1966384 - Convert unified search button to a type=menu toolbarbutton to open popup natively. r=search-reviewers,urlbar-reviewers,daisuke" for causing ba failures @ browser_test_focus_urlbar.js

Comment 5

[amarc]

Backed out for causing ba failures @ browser_test_focus_urlbar.js

• Backout link
• Push with failures
• Failure Log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/43401feaf929
https://hg.mozilla.org/integration/autoland/rev/570a8e2333be
Convert unified search button to a type=menu toolbarbutton to open popup natively. r=search-reviewers,urlbar-reviewers,daisuke

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/55b2aa39f52c
https://hg.mozilla.org/integration/autoland/rev/01064dcdd2ab
Revert "Bug 1966384 - Convert unified search button to a type=menu toolbarbutton to open popup natively. r=search-reviewers,urlbar-reviewers,daisuke" for causing fenix debug failures

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing fenix debug failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/01064dcdd2abd69e53837af1b41d6d6a0c8ac30e

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | org.mozilla.fenix.trackingprotection.TrackingProtectionPanelInteractorTest.WHEN onBackPressed is called THEN call popBackStack and navigate | java.lang.InstantiationError: kotlin.jvm.functions.Function1

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/755ae73bf43b
https://hg.mozilla.org/integration/autoland/rev/08737413f15b
Reapply "Bug 1966384 - Convert unified search button to a type=menu toolbarbutton to open popup natively. r=search-reviewers,urlbar-reviewers,daisuke" for causing fenix debug failures

Comment 10

[Sandor Molnar[:smolnar]]

Backed out by mistake
relanded

Comment 11

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/08737413f15b