1966411 - Flatpak repacking failing due to `KeyError: 'PKG_NAME'`

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Bastien Orivel [:eijebong]]

1950511 renamed all DEB_PKG_NAME to PKG_NAME, dropping the DEB_ prefix but forgot one in python/mozbuild/mozbuild/repackaging/flatpak.py

Failure: https://treeherder.mozilla.org/jobs?repo=try&revision=7a4fae1b2f80a0d8e497496b7e5285dea07e0b64&selectedTaskRun=BlUd4PlTQDK8ROvQycrtLQ.0

[task 2025-05-14T14:09:52.051Z] 14:09:52     INFO -  KeyError: 'PKG_NAME'
[task 2025-05-14T14:09:52.052Z] 14:09:52     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/mach_commands.py", line 3743, in repackage_flatpak
[task 2025-05-14T14:09:52.052Z] 14:09:52     INFO -      repackage_flatpak(
[task 2025-05-14T14:09:52.052Z] 14:09:52     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/repackaging/flatpak.py", line 166, in repackage_flatpak
[task 2025-05-14T14:09:52.052Z] 14:09:52     INFO -      desktop = generate_browser_desktop_entry(
[task 2025-05-14T14:09:52.052Z] 14:09:52     INFO -                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2025-05-14T14:09:52.052Z] 14:09:52     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/repackaging/desktop_file.py", line 53, in generate_browser_desktop_entry
[task 2025-05-14T14:09:52.052Z] 14:09:52     INFO -      return _generate_browser_desktop_entry(build_variables, localizations)
[task 2025-05-14T14:09:52.052Z] 14:09:52     INFO -             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[task 2025-05-14T14:09:52.052Z] 14:09:52     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/repackaging/desktop_file.py", line 213, in _generate_browser_desktop_entry
[task 2025-05-14T14:09:52.052Z] 14:09:52     INFO -      "command": f"{build_variables['PKG_NAME']} --new-window %u",
[task 2025-05-14T14:09:52.052Z] 14:09:52     INFO -                    ~~~~~~~~~~~~~~~^^^^^^^^^^^^
[task 2025-05-14T14:09:52.100Z] 14:09:52     INFO - Return code: 1

Comment 1

[Bastien Orivel [:eijebong]]

Attachment: Bug 1966411 - Drop the `DEB_` prefix in flatpak repackaging variables. r=#releng-reviewers

This fixes a regression from 1950511 which dropped the DEB_ prefix
everywhere except for this instance.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1950511

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23bfe41d12f0
Drop the `DEB_` prefix in flatpak repackaging variables. r=releng-reviewers,jcristau DONTBUILD

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/23bfe41d12f0