1966508 - Hard-coded English string "Sign in" in edit bookmark dialog

Status: RESOLVED FIXED

(Firefox for Android :: Bookmarks, defect)

Description

[Jørgen Rasmussen]

Attachment: Save In

Steps to reproduce

1. Open Firefox for Android.
2. If language of GUI is English, change language to Dansk/Danish.
3. Go to a webpage you haven't bookmarked.
4. Press the menu button in Firefox (tree dots).
5. Select Tilføj (Add) next to Bogmærker (Bookmarks).
6. Press the Rediger (Edit) button.

Expected behavior

The text "Save In" Should be translated.

Actual behavior

The text "Save In" is displayed in English

Device information

• Firefox version: 138.0.2 and Firefox Nightly 140.0a1
• Android device model: Galaxy A21s
• Android OS version: 12

Any additional information?

Note the capital I in "Save In".
There is a string on Pontoon with a lower i. https://pontoon.mozilla.org/da/firefox-for-android/all-resources/?search=Save+In&string=309784
The issue is also present in the German/Deutsch version.

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

I don't have an Android device to check against other languages, but this string was localized in Pontoon 8months ago, so it should appear in English on device (which it is currently not, according to reporter).
Flaggin Clare so she can help advise

Comment 2

[Francesco Lodolo [:flod]]

That looks very much hard-coded

Apparently introduced in bug 1902100 (for fx132).

Comment 3

[Jørgen Rasmussen]

The string in https://pontoon.mozilla.org/da/firefox-for-android/all-resources/?search=Save+In&string=309784 is not the string that's missing.
There is "Save In" and "Save in". "Save in" is displayed when a user adds a new bookmarks folder.

Comment 4

[Delphine Lebédel [:delphine - Use needinfo]]

(I also just realized the link to Pontoon that I was given and that I posted above was NOT the string in question, so my comment was misleading)
Flod is correct, that was hardcoded

Comment 5

[Clare So]

Attachment: Edit bookmarks screen

I can reproduce the issue on Firefox v138.0.3 Android. Note the untranslated "Save In" label.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:boek, could you have a look please?

For more information, please visit BugBot documentation.

Comment 8

[Segun Famisa [:segun]]

Attachment: Bug 1966508 - Fix hard-coded "Save In" label

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1308c4745771
https://hg.mozilla.org/integration/autoland/rev/67e4d94b66a1
Fix hard-coded "Save In" label r=android-reviewers,nalexander

Comment 10

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/67e4d94b66a1