1966592 - Extensions with a browserAction do not show up in the extensions panel in a Taskbar Tabs window

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect, P3)

Description

[Alex Cornestean]

Affected Version:
Nightly - 140.0a1/20250514211700

Description:
Extensions which have a clickable button (browserAction) do not show up in the extensions panel of the toolbar extensions button in a Taskbar Tabs window. Oddly enough, extensions without a browserAction do show up in the extensions panel.

Steps to reproduce:

1. Install https://addons.mozilla.org/en-US/firefox/addon/augmented-steam/ (has no browserAction) and https://addons.mozilla.org/en-US/firefox/addon/darkreader/ (has a browserAction)
2. Access https://www.wikipedia.org/ and open it in a Taskbar Tabs window
3. In the Taskbar Tabs window, click the extensions button on the toolbar to open the extensions panel
4. Notice that Dark Reader which has a browserAction is not displayed in the panel, but Augmented Steam which does not have a browserAction is displayed

Actual results:
Extensions with a browserAction are not displayed in the in the extensions panel of the toolbar extensions button in a Taskbar Tabs window, but extensions without a browserAction are displayed.

Expected results:
Both types of extensions should be displayed in the extensions panel in a Taskbar Tabs window, as in the case of the normal browser window.

Comment 1

[Duncan McIntosh [:dmcintosh]]

Attachment: Bug 1966592 - Don't hide extension or overflow buttons in Taskbar Tabs windows. r=nrishel!

.unified-extensions-item solves the problem, but the 'toolbar' selector
means that other oversights don't infect the rest of the UI.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bb2169114ac2
https://hg.mozilla.org/integration/autoland/rev/04bceaf8ca6b
Don't hide extension or overflow buttons in Taskbar Tabs windows. r=nrishel,desktop-theme-reviewers,emilio

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/04bceaf8ca6b

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 5

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (142.0a1/20250624211752).

Extensions with a browserAction are now shown in the extensions panel in a Taskbar Tabs window. The extension buttons can be pinned/unpinned from the toolbar and their popups open as expected. Furthermore, the extensions function as expected as well.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dmcintosh, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox141 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Nick Rishel [:nrishel]]

Behind a pref, no urgency to uplift.