Closed Bug 1966643 Opened 3 months ago Closed 1 month ago

Add tests for spotlight modal sizing

Categories

(Firefox :: Messaging System, defect, P2)

Product:
Firefox
Component:
Messaging System
Type:
defect
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
142 Branch
Iteration:
142.1 - Jun 23 - Jul 4
Tracking Flags:
Tracking Status
firefox142 --- fixed

People

(Reporter: emilio, Assigned: mviar)

References

Details

Attachments

(1 file)

Bug 1966643 - Add test to confirm Spotlight modal has expected sizing
48 bytes, text/x-phabricator-request
Details | Review

It's rather hacky because it relies on the dialog being full-size of the window. It seems there's no test which would've caught bug 1966579...

Hi Emilio, can you provide a bit more context around what exactly is happening? Is the issue that the modal content is incorrectly sized for the window resolution?

Flags: needinfo?(emilio)

What's happening is that there are no tests for bugs like bug 1966579, which render nightly unusable because of the ToS dialog.

Right now that one was fixed by backout, but ideally we have a way of preventing that from happening again. I'd be happy to write some tests if you point me to relevant places, but also I'd expect someone more familiar with the messaging system would do that in a lot less time :)

Flags: needinfo?(emilio)
Assignee: nobody → mviar
Severity: -- → S4
Points: --- → 2
Priority: -- → P2
Iteration: --- → 141.1 - May 26 - Jun 6
Iteration: 141.1 - May 26 - Jun 6 → 141.2 - Jun 9 - Jun 20
Iteration: 141.2 - Jun 9 - Jun 20 → 142.1 - Jun 23 - Jul 4
Iteration: 142.1 - Jun 23 - Jul 4 → 142.2 - Jul 7 - Jul 18
Iteration: 142.2 - Jul 7 - Jul 18 → 142.1 - Jun 23 - Jul 4
Pushed by mviar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/45e5f5553bad https://hg.mozilla.org/integration/autoland/rev/6b2747949aa8 Add test to confirm Spotlight modal has expected sizing r=omc-reviewers,emcminn

https://hg.mozilla.org/mozilla-central/rev/6b2747949aa8

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox142: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
QA Whiteboard: [qa-triage-done-c143/b142]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: