Closed Bug 1966660 Opened 3 months ago Closed 2 months ago

browser_all_files_referenced.js raises failures when migrating urlbar code to moz-src

Categories

(Firefox :: General, task)

task

Tracking

()

RESOLVED FIXED
142 Branch
Tracking Status
firefox142 --- fixed

People

(Reporter: standard8, Assigned: Gijs)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

I tried porting the address bar code to moz-src using the patch I've just attached to bug 1950725. This was generated with:

python3.13 ./mach use-moz-src browser/components/urlbar/moz.build

When running on try, a failure appeared in browser_all_files_referenced.js:

TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | file only referenced from unreferenced files: chrome://devtools/skin/images/open-inspector.svg referenced from moz-src:///browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs

I've spent a while digging into browser_all_files_referenced.js to try and figure out what's wrong, but I can't see anything obvious. I'm also not sure I understand enough about how it is working to effectively debug it.

Also allow moz-src urls with 2 slashes to prep for having non-empty hosts in those URLs in future.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
See Also: → 1664791
Pushed by gijskruitbosch@gmail.com: https://github.com/mozilla-firefox/firefox/commit/ec5b01485d73 https://hg.mozilla.org/integration/autoland/rev/17e07e53e566 fix browser_all_files_referenced.js to avoid complaining about moz-src references to devtools files, r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
QA Whiteboard: [qa-triage-done-c143/b142]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: