1966674 - We never call nsDocShellLoadState::SetNavigationAPIState

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Andreas Farre [:farre]]

Since we don't the NavigateEvent doesn't have all its state.

Comment 1

[Adam Vandolder [:avandolder]]

Attachment: Bug 1966674 - Part 1: Pass serializedState to BrowsingContext::Navigate and use it to set nsDocShellLoadState::SetNavigationAPIState. r?#dom-core

Comment 2

[Adam Vandolder [:avandolder]]

Attachment: Bug 1966674 - Part 2: Add NavigationAPIState to DocShellLoadStateInit. r?#dom-core

Comment 3

[Adam Vandolder [:avandolder]]

Attachment: Bug 1966674 - Part 3: Copy the NavigationAPIState to the new loadState when retargeting. r?#dom-core

Comment 4

[Adam Vandolder [:avandolder]]

Attachment: Bug 1966674 - Part 6: Copy over the NavigationAPIState when initializing a SessionHistoryInfo from a nsDocShellLoadState. r?#dom-core

Comment 5

[Adam Vandolder [:avandolder]]

Attachment: Bug 1966674 - Part 4: Add NavigationAPIState to the new NavigationDestination when firing a push/replace/reload navigate event. r?#dom-core

Comment 6

[Adam Vandolder [:avandolder]]

Attachment: Bug 1966674 - Part 5: Stop sharing the Navigation API State among session history infos. r?#dom-core

Comment 7

[Adam Vandolder [:avandolder]]

Attachment: Bug 1966674 - Part 7: Add the destinationNavigationAPIState to the newly-created session history entry. r?#dom-core

Comment 8

[Adam Vandolder [:avandolder]]

Attachment: Bug 1966674 - Part 8: Update test expectations. r?#dom-core

Comment 9

[Adam Vandolder [:avandolder]]

Attachment: Bug 1966674 - Part 9: Make Navigation API State-related naming and types more consistent. r?jjaschke

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2c5f2a0d7a11
https://hg.mozilla.org/integration/autoland/rev/a66672d30644
Part 1: Pass serializedState to BrowsingContext::Navigate and use it to set nsDocShellLoadState::SetNavigationAPIState. r=dom-core,jjaschke
https://github.com/mozilla-firefox/firefox/commit/e1bb90b66f88
https://hg.mozilla.org/integration/autoland/rev/6172dc55e172
Part 2: Add NavigationAPIState to DocShellLoadStateInit. r=dom-core,jjaschke
https://github.com/mozilla-firefox/firefox/commit/b03115e1a301
https://hg.mozilla.org/integration/autoland/rev/bb84f6e00dd1
Part 3: Copy the NavigationAPIState to the new loadState when retargeting. r=dom-core,jjaschke
https://github.com/mozilla-firefox/firefox/commit/b6acd9bb9e71
https://hg.mozilla.org/integration/autoland/rev/99470f7a5b37
Part 4: Add NavigationAPIState to the new NavigationDestination when firing a push/replace/reload navigate event. r=dom-core,jjaschke
https://github.com/mozilla-firefox/firefox/commit/19d1b3d2a3c0
https://hg.mozilla.org/integration/autoland/rev/29cea3a511e4
Part 5: Stop sharing the Navigation API State among session history infos. r=dom-core,jjaschke
https://github.com/mozilla-firefox/firefox/commit/3e04ec90d3f8
https://hg.mozilla.org/integration/autoland/rev/147a79ebfc9e
Part 6: Copy over the NavigationAPIState when initializing a SessionHistoryInfo from a nsDocShellLoadState. r=dom-core,jjaschke
https://github.com/mozilla-firefox/firefox/commit/3389f230998d
https://hg.mozilla.org/integration/autoland/rev/0057bb3d85dd
Part 7: Add the destinationNavigationAPIState to the newly-created session history entry. r=dom-core,jjaschke
https://github.com/mozilla-firefox/firefox/commit/3e33759f74a1
https://hg.mozilla.org/integration/autoland/rev/97105d0db120
Part 8: Update test expectations. r=dom-core,smaug
https://github.com/mozilla-firefox/firefox/commit/0f1dde951669
https://hg.mozilla.org/integration/autoland/rev/f3762c527f38
Part 9: Make Navigation API State-related naming and types more consistent. r=jjaschke

Comment 11

[amarc]

https://hg.mozilla.org/mozilla-central/rev/a66672d30644
https://hg.mozilla.org/mozilla-central/rev/6172dc55e172
https://hg.mozilla.org/mozilla-central/rev/bb84f6e00dd1
https://hg.mozilla.org/mozilla-central/rev/99470f7a5b37
https://hg.mozilla.org/mozilla-central/rev/29cea3a511e4
https://hg.mozilla.org/mozilla-central/rev/147a79ebfc9e
https://hg.mozilla.org/mozilla-central/rev/0057bb3d85dd
https://hg.mozilla.org/mozilla-central/rev/97105d0db120
https://hg.mozilla.org/mozilla-central/rev/f3762c527f38