1966721 - Improve PDF.js startup perf by starting the worker as soon as possible

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, enhancement)

Description

[Calixte Denizet (:calixte)]

The worker takes some time to load its module so we've to wait a bit for it.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] Use the worker created when the child actor has been (bug 1966721) (#19935)

Comment 2

[Calixte Denizet (:calixte)]

Attachment: Bug 1966721 - Initialize the pdf.js worker just before the actor is created to reduce the startup delay r=#pdfjs-reviewers

Comment 3

[Calixte Denizet (:calixte)]

For now I didn't land the m-c patch because the added test is failing in verify mode, so I've to fix it first.

Comment 4

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:calixte, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 5

[Calixte Denizet (:calixte)]

The test I added is failing in the CI in verify mode, so I need to rewrite it a bit.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3e8ee7b6ceb9
https://hg.mozilla.org/integration/autoland/rev/01e214d47ab4
Initialize the pdf.js worker just before the actor is created to reduce the startup delay r=pdfjs-reviewers,robwu

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9d51f1ff2b80
https://hg.mozilla.org/integration/autoland/rev/82078fae3281
Revert "Bug 1966721 - Initialize the pdf.js worker just before the actor is created to reduce the startup delay r=pdfjs-reviewers,robwu" for causing bc failures in browser_pdfjs_preloaded_worker.js

Comment 8

[Cristian Tuns]

Backed out for causing bc failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/pdfjs/test/browser_pdfjs_preloaded_worker.js | test_no_worker_for_non_pdf_document - Uncaught exception in test - NotFoundError: WindowGlobalChild.getActor: No such JSWindowActor 'Pdfjs'

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/be3b7c354a7f
https://hg.mozilla.org/integration/autoland/rev/156968f950e9
Initialize the pdf.js worker just before the actor is created to reduce the startup delay r=pdfjs-reviewers,robwu

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/156968f950e9

Comment 11

[Performance Sheriff Bot]

Perfherder has detected a talos performance change from push 01e214d47ab4adbe21dcddcb2be9e26d38cb72bd.

No action is required from the author; this comment is provided for informational purposes only.

Improvements	Test	Platform	Options	Absolute values [old vs new]
45%	pdfpaint issue12295.pdf (doc)	linux2404-64-shippable	e10s fission stylo webrender	2,249.15 ms -> 1,233.60 ms
42%	pdfpaint issue12295.pdf (doc)	linux2404-64-shippable	e10s fission stylo webrender-sw	1,835.11 ms -> 1,056.74 ms
35%	pdfpaint issue14462_reduced.pdf (doc)	macosx1470-64-shippable	e10s fission stylo webrender	277.54 ms -> 181.32 ms
31%	pdfpaint issue17981.pdf (doc)	linux2404-64-shippable	e10s fission stylo webrender	1,480.13 ms -> 1,027.26 ms
30%	pdfpaint issue14497.pdf (doc)	macosx1470-64-shippable	e10s fission stylo webrender	274.10 ms -> 191.01 ms
...	...	...	...	...
6%	pdfpaint issue9552.pdf (doc)	windows11-64-24h2-shippable	e10s fission stylo webrender-sw	259.46 ms -> 243.89 ms

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Comment 12

[Performance Sheriff Bot]

Perfherder has detected a talos performance change from push 01e214d47ab4adbe21dcddcb2be9e26d38cb72bd.

No action is required from the author; this comment is provided for informational purposes only.

Improvements	Test	Platform	Options	Absolute values [old vs new]
45%	pdfpaint issue12295.pdf (doc)	linux2404-64-shippable	e10s fission stylo webrender	2,249.15 ms -> 1,233.60 ms
42%	pdfpaint issue12295.pdf (doc)	linux2404-64-shippable	e10s fission stylo webrender-sw	1,835.11 ms -> 1,056.74 ms
35%	pdfpaint issue14462_reduced.pdf (doc)	macosx1470-64-shippable	e10s fission stylo webrender	277.54 ms -> 181.32 ms
31%	pdfpaint issue17981.pdf (doc)	linux2404-64-shippable	e10s fission stylo webrender	1,480.13 ms -> 1,027.26 ms
30%	pdfpaint issue14497.pdf (doc)	macosx1470-64-shippable	e10s fission stylo webrender	274.10 ms -> 191.01 ms
...	...	...	...	...
6%	pdfpaint issue9552.pdf (doc)	windows11-64-24h2-shippable	e10s fission stylo webrender-sw	259.46 ms -> 243.89 ms

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Release Note Request (optional, but appreciated)
[Why is this notable]: felt user improvement
[Affects Firefox for Android]: dunno ?
[Suggested wording]: Firefox's built-in PDF viewer now starts up to 45% faster.
[Links (documentation, blog post, etc)]: