1966880 - Simplify ReviewPromptController to drop eligibility logic

Status: RESOLVED FIXED

(Firefox for Android :: Experimentation and Telemetry, task)

Description

[Marcin Koziński]

Duplicate ReviewPromptController into PlayStoreReviewPromptController, keeping just the code wrapping ReviewManager, but dropping any conditional logic from shouldShowPrompt(). This will allow moving the logic to a store/reducer/middleware and showing the prompt from different places (directly from HomeFragment or from the custom review prompt).

Comment 1

[Marcin Koziński]

Attachment: Bug 1966880 - Part 1: Extract tracking number of app launches from ReviewPromptController

Comment 2

[Marcin Koziński]

Attachment: Bug 1966880 - Part 2: Extract Play In-App Review API usage into a separate controller

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/815f4bf2cc83
https://hg.mozilla.org/integration/autoland/rev/1a248cf91bf5
Part 1: Extract tracking number of app launches from ReviewPromptController r=android-reviewers,twhite
https://github.com/mozilla-firefox/firefox/commit/93f397746224
https://hg.mozilla.org/integration/autoland/rev/6cce9e5542b3
Part 2: Extract Play In-App Review API usage into a separate controller r=android-reviewers,twhite

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f69fb6ccdd9f
https://hg.mozilla.org/integration/autoland/rev/ef988adc220a
Revert "Bug 1966880 - Part 2: Extract Play In-App Review API usage into a separate controller r=android-reviewers,twhite" for causing fenix debug failures

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing fenix debug failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/ef988adc220a2121c221138f26130e777ca448da

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | org.mozilla.fenix.trackingprotection.TrackingProtectionPanelInteractorTest.WHEN onBackPressed is called THEN call popBackStack and navigate | java.lang.InstantiationError: kotlin.jvm.functions.Function1

Comment 6

[Marcin Koziński]

Thanks for looking out for failures, but looks like the linked one is just an intermittent test failure and the test is unrelated to changes in this stack. Just checked and the test runs fine locally.

Can we please land it back?

Comment 7

[Marcin Koziński]

I'm going to rebase, split the stack into two separate patches and try landing them separately.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cd8148d237e9
https://hg.mozilla.org/integration/autoland/rev/5482c2acc814
Part 1: Extract tracking number of app launches from ReviewPromptController r=android-reviewers,twhite

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5482c2acc814

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4f8cecc574ea
https://hg.mozilla.org/integration/autoland/rev/bfc6a1e723c3
Part 2: Extract Play In-App Review API usage into a separate controller r=android-reviewers,twhite

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://github.com/mozilla-firefox/firefox/commit/4f8cecc574ea411437bc9a05170d83f15a2f9624
https://hg.mozilla.org/mozilla-central/rev/bfc6a1e723c3