1966912 - Remove addTab's `index` alias for the `tabIndex` parameter

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task, P3)

Description

[Dão Gottwald [:dao]]

Bug 1966617 added the tabIndex parameter to addTab but kept index as an alias since there are quite a few call sites that need to be updated. Let's do that here.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1966912 - Remove addTab's `index` alias for the `tabIndex` parameter. r=#extension-reviewers,#sessionstore-reviewers,#tabbrowser-reviewers,robwu,dwalker

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ea64fea64c5
Remove addTab's `index` alias for the `tabIndex` parameter. r=extension-reviewers,sessionstore-reviewers,tabbrowser-reviewers,robwu,dwalker

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2811dbc92ab7
Revert "Bug 1966912 - Remove addTab's `index` alias for the `tabIndex` parameter. r=extension-reviewers,sessionstore-reviewers,tabbrowser-reviewers,robwu,dwalker" for causing remote failures @ browser_TabManager.js

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing remote failures @ browser_TabManager.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/2811dbc92ab7573c3abc12b4848b289d5487c336

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | remote/shared/test/browser/browser_TabManager.js | undefined assertion name - Got [object XULElement], expected [object XULElement]

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22d6922a8bd1
Remove addTab's `index` alias for the `tabIndex` parameter. r=extension-reviewers,sessionstore-reviewers,tabbrowser-reviewers,robwu,dwalker

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/22d6922a8bd1