Closed Bug 1966955 Opened 1 year ago Closed 6 months ago

Ultimate guitar tabs are copied with extra newlines

Categories

(Web Compatibility :: Site Reports, defect, P2)

Tracking

(Webcompat Priority:P2, Webcompat Score:7, firefox147 fixed)

RESOLVED FIXED
Webcompat Priority P2
Webcompat Score 7
Tracking Status
firefox147 --- fixed

People

(Reporter: gregtatum, Unassigned)

References

()

Details

(Keywords: webcompat:platform-bug, webcompat:site-report, Whiteboard: [webcompat:sightline])

User Story

platform:windows,mac,linux,android
impact:annoyance
configuration:general
affects:all
branch:release
diagnosis-team:dom
user-impact-score:600

Steps to reproduce:

Results in Chrome:

e|--------------------------------------------------------------------|
B|--10-------8-------7-------8-------8-------6-------5-------6--------|
G|-------7-------7-------7-------7-------5-------5-------5-------5----|
D|-----8---8---8---8---8---8---8---8---7---7---7---7---7---7---7---7--|
A|--------------------------------------------------------------------|
E|--------------------------------------------------------------------|

Results in Safari:

e|--------------------------------------------------------------------|
B|--10-------8-------7-------8-------8-------6-------5-------6--------|
G|-------7-------7-------7-------7-------5-------5-------5-------5----|
D|-----8---8---8---8---8---8---8---8---7---7---7---7---7---7---7---7--|
A|--------------------------------------------------------------------|
E|--------------------------------------------------------------------|

Results in Firefox

e|--------------------------------------------------------------------|

B|--10-------8-------7-------8-------8-------6-------5-------6--------|

G|-------7-------7-------7-------7-------5-------5-------5-------5----|

D|-----8---8---8---8---8---8---8---8---7---7---7---7---7---7---7---7--|

A|--------------------------------------------------------------------|

E|--------------------------------------------------------------------|

Expected results: The copied guitar tabs should only have one space between the lines, and not two, similar to Chrome and Safari.

Summary: Ultimate guitar tabs don't copy properly → Ultimate guitar tabs are copied with extra newlines
Severity: -- → S3
User Story: (updated)
Webcompat Priority: --- → P2
Webcompat Score: --- → 6
Priority: -- → P2
Whiteboard: [webcompat:sightline]
Webcompat Score: 6 → 7
Webcompat Score: 7 → 6

Looks like there's no trivial fix at the moment.

Webcompat Score: 6 → 7
User Story: (updated)

This is because there's \r\n in <pre>, I think there's an existing bug...

Edit: Oh, comment #1.

User Story: (updated)

Ah interesting. In Chrome if I look in DevTools at $0.innerText it contains the \r\n in the text. When I run copy($0.innerText) in Chrome the \r values are stripped out. So it appears to be normalizing the text while copying. Could this actually be trivially fixed by handling this normalization step in the copy handler code?

Bug 1650720 has been fixed and is included in today's Nightly build (2025-11-11).
I could not reproduce this anymore on Nightly. Hi Greg, would you mind helping to confirm as well? Thanks!

Flags: needinfo?(gtatum)

(In reply to Edgar Chen [:edgar] from comment #4)

Bug 1650720 has been fixed and is included in today's Nightly build (2025-11-11).
I could not reproduce this anymore on Nightly. Hi Greg, would you mind helping to confirm as well? Thanks!

I can also confirm this is fixed.

Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED

Thanks for the fix! I can confirm it's working as well. Now to just get good enough at guitar to play Zelda songs to my heart's content.

Flags: needinfo?(gtatum)
You need to log in before you can comment on or make changes to this bug.