1966984 - [wpt-sync] Sync PR 52605 - [ident] Implement ident() function fundamentals

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52605 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52605
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[ident] Implement ident() function fundamentals

The ident() function allows identifiers to be constructed dynamically
by e.g. concatenating strings and integers. This CL implements
the "bare minimum" to get the feature going, and only supports
view-transition-name for now. It may accidentally already work
in other properties. If that's the case, then future CLs will
land WPTs for those properties gradually.

Note that this feature has several open questions, and this CL does
not try to answer all of them. Some important ones are filed
as dependencies of Issue 384930424.

Bug: 384930424
Change-Id: I0fea0eb3163c3ac3fead8a139220c571a1aa5628
Reviewed-on: https://chromium-review.googlesource.com/6551725
WPT-Export-Revision: 7b7b1103d5c08a8071583e3f03b0ccf091354e1d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4d97ac823024af91f014ff19c147d2e6b423ca5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 17 subtests

Status Summary

Firefox

OK : 2
PASS: 4
FAIL: 24

Chrome

OK : 2
PASS: 4
FAIL: 24

Safari

OK : 2
PASS: 4
FAIL: 24

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-values/ident-function-computed.html [wpt.fyi]
  • Property view-transition-name value 'ident(myident)': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property view-transition-name value 'ident("myident")': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property view-transition-name value 'ident("myident" 3)': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property view-transition-name value 'ident(3 "myident")': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property view-transition-name value 'ident("my" "ident")': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property view-transition-name value 'ident(my "ident")': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property view-transition-name value 'ident("my" ident)': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property view-transition-name value 'ident(my ident)': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property view-transition-name value 'ident(-- myident)': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property view-transition-name value 'ident(my 3 3 3 3 ident)': FAIL (Chrome: FAIL, Safari: FAIL)
  • Property view-transition-name value 'ident("myident" 42)': FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-values/ident-function-parsing.html [wpt.fyi]
  • e.style['view-transition-name'] = "ident(myident)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['view-transition-name'] = "ident( myident)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['view-transition-name'] = "ident(myident )" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['view-transition-name'] = "ident("myident")" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['view-transition-name'] = "ident("myident" 3)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['view-transition-name'] = "ident(3 "myident")" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['view-transition-name'] = "ident("my" "ident")" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['view-transition-name'] = "ident(my "ident")" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['view-transition-name'] = "ident("my" ident)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['view-transition-name'] = "ident(my ident)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['view-transition-name'] = "ident(-- myident)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['view-transition-name'] = "ident(my 3 3 3 3 ident)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • e.style['view-transition-name'] = "ident("myident" 42)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1966984 [wpt PR 52605] - [ident] Implement ident() function fundamentals, a=testonly

Automatic update from web-platform-tests
[ident] Implement ident() function fundamentals

The ident() function allows identifiers to be constructed dynamically
by e.g. concatenating strings and integers. This CL implements
the "bare minimum" to get the feature going, and only supports
view-transition-name for now. It may accidentally already work
in other properties. If that's the case, then future CLs will
land WPTs for those properties gradually.

Note that this feature has several open questions, and this CL does
not try to answer all of them. Some important ones are filed
as dependencies of Issue 384930424.

Bug: 384930424
Change-Id: I0fea0eb3163c3ac3fead8a139220c571a1aa5628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6551725
Reviewed-by: Rune Lillesveen <[e-mail]>
Commit-Queue: Anders Hartvoll Ruud <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1461990}

--

wpt-commits: 50787b55380d0310268cc40f02242908b41c6c42
wpt-pr: 52605

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1966984 [wpt PR 52605] - Update wpt metadata, a=testonly

wpt-pr: 52605
wpt-type: metadata

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3073e58bc7d
[wpt PR 52605] - [ident] Implement ident() function fundamentals,
https://hg.mozilla.org/integration/autoland/rev/a83d49012077
[wpt PR 52605] - Update wpt metadata,

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f3073e58bc7d
https://hg.mozilla.org/mozilla-central/rev/a83d49012077