1967196 - Implement a policy to prevent multiple popups from appearing simultaneously

Status: RESOLVED FIXED

(Toolkit :: PopupNotifications and Notification Bars, enhancement, P2)

Description

[Andrea Marchesini [:baku]]

We're facing multiple bugs caused by overlapping popups, often triggered by malicious sites or extensions. Multiple popups are a poor UX pattern and confuse users. A centralized policy allows async or low-priority popups to be queued and displayed safely.

Comment 1

[Andrea Marchesini [:baku]]

The logic I would like to implement is as follows:

• Popups with the queueable attribute set to true can be displayed asynchronously.
• Only one queueable popup can be visible at a time. The next one is shown once the current one is dismissed or hidden.
• When a non-queueable popup is shown, any currently visible queueable popup is dismissed.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1967196 - Introduction of a Popup queue,

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1967196 - Expose the popup queue logic to webRTC dialogs,

Comment 4

[Rob Wu [:robwu]]

This is a blocker to expanding the availability of the action.openPopup() extension API. The current patches here offer the ability to queue panels, but do not apply that to extension popups. Implementing that could be a part of bug 1799347 or a separate bug.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cc8b8d3f5545
https://hg.mozilla.org/integration/autoland/rev/d79a28a39a06
Revert "Bug 1967196 - Expose the popup queue logic to webRTC dialogs, r=emz" for causing bc failures @ browser_TabUnloader.js

Comment 6

[amarc]

Backed out for causing bc failures @ browser_TabUnloader.js

• Backout link
• Push with failures
• Failure Log
• Failure Log -> Mn failure

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9d3c24dba0da
https://hg.mozilla.org/mozilla-central/rev/b0a7b39f2c56
Introduction of a Popup queue, r=smaug,Gijs

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4887d0ed02ab
https://hg.mozilla.org/integration/autoland/rev/ea9a8eadf9b4
Introduction of a Popup queue, r=smaug,Gijs
https://github.com/mozilla-firefox/firefox/commit/901ee0d445e7
https://hg.mozilla.org/integration/autoland/rev/a90471f599bc
Expose the popup queue logic to webRTC dialogs, r=emz

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ea9a8eadf9b4
https://hg.mozilla.org/mozilla-central/rev/a90471f599bc

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3c7259d00dde
https://hg.mozilla.org/integration/autoland/rev/9945a9839081
Revert "Bug 1967196 - Expose the popup queue logic to webRTC dialogs, r=emz" for causing Mn assertion failures @ ClearOnShutdown.cpp

Comment 11

[Sandor Molnar[:smolnar]]

Backed out for causing Mn assertion failures @ ClearOnShutdown.cpp

Backout link: hg.mozilla.org/integration/autoland/rev/9945a98390811f55b4364894d97c45143e78b513

Push with failures

Failure log -> Assertion failure: false (ClearOnShutdown for phase that already was cleared), at /builds/worker/checkouts/gecko/xpcom/base/ClearOnShutdown.cpp:20

Comment 12

[Rob Wu [:robwu]]

Stack of crash, for future reference:

MOZ_ASSERT(false) (ClearOnShutdown for phase that already was cleared) [@ mozilla::ClearOnShutdown_Internal::InsertIntoShutdownList] | browser/components/sidebar/tests/marionette/test_initialize_vertical_tabs.py TestInitializeVerticalTabs.test_restore_tabstrip_customizations

0 xul.dll!mozilla::ClearOnShutdown_Internal::InsertIntoShutdownList(mozilla::ClearOnShutdown_Internal::ShutdownObserver*, mozilla::ShutdownPhase) [ClearOnShutdown.cpp:...]
1 xul.dll!mozilla::ClearOnShutdown(mozilla::StaticRefPtr<PopupQueue>*, mozilla::ShutdownPhase) [ClearOnShutdown.cpp:...]
2 xul.dll!PopupQueue::GetInstance() [PopupQueue.cpp:...]
3 xul.dll!nsXULPopupManager::HidePopup(mozilla::dom::Element*, mozilla::EnumSet<HidePopupOption,unsigned char>, mozilla::dom::Element*) [nsXULPopupManager.cpp:...]
4 xul.dll!nsXULTooltipListener::HideTooltip() [nsXULTooltipListener.cpp:...]
5 xul.dll!nsXULTooltipListener::~nsXULTooltipListener() [nsXULTooltipListener.cpp:...]
6 xul.dll!nsXULTooltipListener::Release() [nsXULTooltipListener.cpp:...]
7 xul.dll!mozilla::dom::CallbackObjectHolder<mozilla::dom::EventListener,nsIDOMEventListener>::UnlinkSelf() [CallbackObject.h:...]
8 xul.dll!mozilla::dom::CallbackObjectHolder<mozilla::dom::EventListener,nsIDOMEventListener>::~CallbackObjectHolder() [CallbackObject.h:...]
9 xul.dll!mozilla::EventListenerManager::Listener::~Listener() [EventListenerManager.h:...]
...
15 xul.dll!mozilla::EventListenerManager::ListenerArray::Release() [EventListenerManager.h:...]
...
24 xul.dll!mozilla::EventListenerManager::EventListenerMap::Clear() [EventListenerManager.h:...]
25 xul.dll!mozilla::EventListenerManager::RemoveAllListenersSilently() [EventListenerManager.cpp:...]
26 xul.dll!mozilla::EventListenerManager::Disconnect() [EventListenerManager.cpp:...]
27 xul.dll!mozilla::EventListenerManager::cycleCollection::Unlink(void*) [EventListenerManager.cpp:...]

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/718f1d6a6106
https://hg.mozilla.org/integration/autoland/rev/e0f8ad3a2d97
Introduction of a Popup queue, r=smaug,Gijs
https://github.com/mozilla-firefox/firefox/commit/55972e70f352
https://hg.mozilla.org/integration/autoland/rev/6e2ddca9ae51
Expose the popup queue logic to webRTC dialogs, r=emz

Comment 14

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e0f8ad3a2d97
https://hg.mozilla.org/mozilla-central/rev/6e2ddca9ae51