Re-enable python tests for ESLint after update to v9
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Tracking
(Not tracked)
People
(Reporter: standard8, Unassigned)
References
(Depends on 1 open bug)
Details
When switching to the ESLint flat configuration (bug 1881701), I noticed that the python tests for ESLint were failing (./mach python-test tools/lint/test/test_eslint.py).
After some investigation, I've come to the conclusion that --no-ignore is not working correctly for ESLint v8 with the flat configuration. My hope is that when we upgrade to v9, the issue will fix itself (the documentation implies it should work in v9). Hence, I'm deferring fixing for now, and we'll look at it after the upgrade.
If upgrading to v9 doesn't work, then we'll investigate an alternate fix.
|
||
Comment 1•1 year ago
|
||
The eslint v9 bug bug was closed. Can we unskip the tests at https://searchfox.org/firefox-main/diff/05fa2d5325a63f0cc40761e9779631331f0a24d5/tools/lint/test/test_eslint.py#49 now?
I came across this because I was writing a unit test for the stylelint linter that exercised the prettier code path, and to my surprise prettier did not do anything in the test. Then I looked for the coverage that we have for prettier, and it seems that we have none since the prettier tests for eslint were disabled.
|
Reporter | |
Comment 2•1 year ago
|
||
I haven't tested this recently, but hopefully we can unskip these now. I can't remember if it is simple unskipping or needs a bit of work. Might get time to look next week, unless anyone else wants to take this on.
Description
•