1967261 - Create icon channels with the correct LoadInfo from the beginning

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Tom Schuster]

The GTK nsIconChannel implementation first creates a channel using a dummy LoadInfo and immediately afterwards the actual LoadInfo is set. The Android implementation works similarly.

We do the same thing in the somewhat unrelated PageIconProtocolHandler. There was some discussion about this behavior when fixing a null deref in bug 1627644. I don't really see any real justification for why we don't just create the channel with the correct LoadInfo directly there either.

Comment 1

[Tom Schuster]

Attachment: Bug 1967261 - Create nsIconChannel with the correct nsILoadInfo from the beginning. r?#necko-reviewers

Comment 2

[Tom Schuster]

Attachment: Bug 1967261 - Create channel with the correct nsILoadInfo from the beginning in PageIconProtocolHandler. r?#necko-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed3f79cc6c40
Create nsIconChannel with the correct nsILoadInfo from the beginning. r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/16681958c0ea
Create channel with the correct nsILoadInfo from the beginning in PageIconProtocolHandler. r=necko-reviewers,places-reviewers,kershaw,Standard8

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ed3f79cc6c40
https://hg.mozilla.org/mozilla-central/rev/16681958c0ea