Closed Bug 1967328 Opened 8 months ago Closed 5 months ago

Create a Nimbus feature for session restore with variable for controlling whether the session restore is ON by default

Categories

(Firefox :: Session Restore, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
143 Branch
Tracking Status
firefox142 --- fixed
firefox143 --- fixed

People

(Reporter: asafko, Assigned: sfoster)

References

Details

(Whiteboard: [fidefe-sidebar])

Attachments

(2 files)

We want to experiment with offering session restore being ON by default for new users.

The Nimbus feature could be:
sessionRestore
description: A feature that controls the default state of the session restore.

And the variable could be:
sessionRestoreEnabled
type: boolean
setPref:
branch: user
pref: unsure if there's an existing pref
description: True if the session restore is ON ("Open previous windows and tabs" in about:preferences).

The variable should persist after the experiment it is used in has ended.

No longer blocks: 1966790
No longer depends on: 1966789
Summary: Create a Nimbus feature for screenshots with variable for controlling whether the tool is added to Firefox setup → Create a Nimbus feature for session restore with variable for controlling whether the session restore is ON by default
Whiteboard: [fidefe-sidebar]
Assignee: nobody → sfoster
Severity: -- → N/A
Priority: -- → P1

The pref to control this behavior is browser.startup.page. It has a few possible integer values:

  • 0: blank (start with only a blank tab)
  • 1: home (load whatever the value of browser.startup.homepage) is in a tab. This is the default value.
  • 2: load last visited page
  • 3: resume previous browser session.

This same pref has UI in about:preferences as the "Open previous windows and tabs" checkbox. Checking the box sets the pref to 3. Un-checking resets it to 1.

The population we want to target is when the user has not set browser.startup.page (i.e. matches preferenceIsUserSet) and its value is the default value of 1. But, if the user gets enrolled in the experiment and uses about:config or the preferences UI to revert the pref, we need a way to unenroll them from the experiment. Using the preferenceIsUserSet filter expression should prevent re-enrolling them at that point.

Attachment #9500695 - Attachment description: WIP: Bug 1967328 - Add a sessionRestore feature and startupBehavior variable for experimenting with enabling session restore by default. → Bug 1967328 - Add a sessionRestore feature and startupBehavior variable for experimenting with enabling session restore by default. r?beth
Pushed by sfoster@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f6f8c88f45aa https://hg.mozilla.org/integration/autoland/rev/a2d1a9c6d3d9 Add a sessionRestore feature and startupBehavior variable for experimenting with enabling session restore by default. r=beth
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
Attachment #9502533 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined: (none) Planned experiment in 142 will not be possible
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: None
  • Risk associated with taking this patch: Low
  • Explanation of risk level: The patch just adds a new nimbus feature and variable
  • String changes made/needed: None
  • Is Android affected?: no
Attachment #9502533 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triage-done-c143/b142]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: