1967564 - Attention indicator does not update when the pinned state of an extension changes in another window

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P2)

Description

[Rob Wu [:robwu]]

In bug 1802925, a bug was fixed that caused the attention dot to not update when an individual extension's action button is pinned via the context menu.

The fix consists of adding an updateAttention() call in response to user-triggered pin state changes: https://searchfox.org/mozilla-central/diff/56d0a1a1eed659ae5cceee35ca793916cbb401c3/browser/base/content/browser-addons.js#1616

This logic works for changes triggered in the same window, but fails to detect changes from another window.

STR:

1. Install a MV3 extension with host permissions and an action button, e.g. https://addons.mozilla.org/en-US/firefox/addon/video-speed-controller-mv3/
2. Visit about:addons and revoke its permissions.
3. Visit any website that previously matched the revoked permissions, e.g. https://example.com/
   • The Extensions Button shows an attention dot.
4. Open a new browser window and open another website that matches the revoked permissions, e.g. https://example.com/
   • The Extensions Button shows an attention dot in this window too.
5. Click on the Extensions Button to open the Extensions Panel, click on the cog next to the extension and choose "Pin to Toolbar".
   • The Extensions Button in the current window (step 4) no longer has the attention dot.
   • The extension's own toolbar button has appeared and shows the attention dot instead.
6. Switch to the original window (from step 4), and look at the extensions button.

Expected:

• The Extensions Button should not have an attention dot in step 6.

Actual:

• The Extensions Button shows an attention dot in step 6.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1967564 - Update attention dot across windows upon (un)pinning

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/034fe92a7934
https://hg.mozilla.org/integration/autoland/rev/9bda54c33584
Update attention dot across windows upon (un)pinning r=zombie

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/9bda54c33584