1967689 - Refactoring in PHC

Status: RESOLVED FIXED

(Core :: Memory Allocator, task)

Description

[Paul Bone [:pbone]]

I started working on Bug 1867191 by doing some refactoring, but it's significant enough that it should be a new bug.

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 1. Fix a comment r=glandium

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 2. Move AllocPageInfo class definition r=glandium

Move this class to the top level.

Comment 3

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 4. Move some code into new methods of AllocPageInfo r=glandium

Comment 4

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 3. Move mFreeTime into AllocPageInfo r=glandium

Comment 5

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 5. Use MOZ_REQUIRES lock annotations in PHC r=glandium

Comment 7

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 6. Add more versions of FdPrintf r=glandium

Comment 8

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 7. Make PHC's debug logging a function r=glandium

This was previously a macro, making it a function allows us to
forward-declare it and write the implementation later in the file.

Comment 9

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 8. Statically allocate PHC::sRegion r=glandium

Comment 10

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt X. Add branch annotations to PHC's hottest paths

Comment 11

[Paul Bone [:pbone]]

Attachment: WIP: Bug 1967689 - pt 10. Move sRegion into PHC

Comment 12

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 9. Move more code into the PHC class r=glandium

A lot of code from outside the PHC class accesses data/methods within it
through the sPHC global. Instead move this code into the PHC class.
Some functions can be moved directly, others are split up and part of
them is moved.

• Move functions into the PHC class
• Move ReuseDelay into the class definition.
• Merge MaybePageRealloc into its caller.

Comment 13

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 10. Move some locking responsability in PHC r=glandium

FragmentationBytes() and GetPageStats() now take the lock instead of
requiring their callers to do it.

Comment 14

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 13. Make more PHC state private within the PHC class r=glandium

Comment 15

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 11. Use mfbt/Array for PHC's page info r=glandium

Comment 16

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt X. Simplify PHC's free hotpath

Use a simplie bounds check on the hot path before deciding what kind of
PHC pointer a particular pointer is.

Comment 17

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 12. Remove duplicate include r=glandium

Comment 18

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 13. AllocVirtualAddresses can fail gracefully r=glandium

Comment 19

[Paul Bone [:pbone]]

Attachment: Bug 1967689 - pt 14. Use FastIsPHCPtr in more places r=glandium

Comment 20

[Phabricator Automation]

Comment on attachment 9494008 [details]
Bug 1967689 - pt X. Simplify PHC's free hotpath

Revision D253289 was moved to bug 1867191. Setting attachment 9494008 [details] to obsolete.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b3b936fe2101
https://hg.mozilla.org/integration/autoland/rev/8b8bc8c68966
pt 1. Fix a comment r=glandium
https://github.com/mozilla-firefox/firefox/commit/5bc69022a4dd
https://hg.mozilla.org/integration/autoland/rev/09a2d6cde40d
pt 2. Move AllocPageInfo class definition r=glandium
https://github.com/mozilla-firefox/firefox/commit/074fe97ce65c
https://hg.mozilla.org/integration/autoland/rev/32ad4c49183b
pt 3. Move mFreeTime into AllocPageInfo r=glandium
https://github.com/mozilla-firefox/firefox/commit/1989d98c86c0
https://hg.mozilla.org/integration/autoland/rev/f09f259858f0
pt 4. Move some code into new methods of AllocPageInfo r=glandium
https://github.com/mozilla-firefox/firefox/commit/cea9a5efbe1e
https://hg.mozilla.org/integration/autoland/rev/ed97bd6c14ee
pt 5. Use MOZ_REQUIRES lock annotations in PHC r=glandium
https://github.com/mozilla-firefox/firefox/commit/e76b04bcd843
https://hg.mozilla.org/integration/autoland/rev/f61fc6f4c805
pt 6. Add more versions of FdPrintf r=glandium
https://github.com/mozilla-firefox/firefox/commit/8255d726b455
https://hg.mozilla.org/integration/autoland/rev/87c39ac9ef52
pt 7. Make PHC's debug logging a function r=glandium
https://github.com/mozilla-firefox/firefox/commit/0284c1c2b634
https://hg.mozilla.org/integration/autoland/rev/350e9c2e5b7d
pt 8. Statically allocate PHC::sRegion r=glandium
https://github.com/mozilla-firefox/firefox/commit/be83f650b58b
https://hg.mozilla.org/integration/autoland/rev/565624be9973
pt 9. Move more code into the PHC class r=glandium
https://github.com/mozilla-firefox/firefox/commit/56035619e2db
https://hg.mozilla.org/integration/autoland/rev/4ca2601fcc2a
pt 10. Move some locking responsability in PHC r=glandium
https://github.com/mozilla-firefox/firefox/commit/a51600df5b77
https://hg.mozilla.org/integration/autoland/rev/8d2c4c757634
pt 11. Use mfbt/Array for PHC's page info r=glandium
https://github.com/mozilla-firefox/firefox/commit/f306a05c62c3
https://hg.mozilla.org/integration/autoland/rev/b7f918e45523
pt 12. Remove duplicate include r=glandium
https://github.com/mozilla-firefox/firefox/commit/7b59f77af93a
https://hg.mozilla.org/integration/autoland/rev/b006227ddb8b
pt 13. AllocVirtualAddresses can fail gracefully r=glandium
https://github.com/mozilla-firefox/firefox/commit/114976a21f82
https://hg.mozilla.org/integration/autoland/rev/d8ccae6defca
pt 14. Use FastIsPHCPtr in more places r=glandium

Comment 22

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8b8bc8c68966
https://hg.mozilla.org/mozilla-central/rev/09a2d6cde40d
https://hg.mozilla.org/mozilla-central/rev/32ad4c49183b
https://hg.mozilla.org/mozilla-central/rev/f09f259858f0
https://hg.mozilla.org/mozilla-central/rev/ed97bd6c14ee
https://hg.mozilla.org/mozilla-central/rev/f61fc6f4c805
https://hg.mozilla.org/mozilla-central/rev/87c39ac9ef52
https://hg.mozilla.org/mozilla-central/rev/350e9c2e5b7d
https://hg.mozilla.org/mozilla-central/rev/565624be9973
https://hg.mozilla.org/mozilla-central/rev/4ca2601fcc2a
https://hg.mozilla.org/mozilla-central/rev/8d2c4c757634
https://hg.mozilla.org/mozilla-central/rev/b7f918e45523
https://hg.mozilla.org/mozilla-central/rev/b006227ddb8b
https://hg.mozilla.org/mozilla-central/rev/d8ccae6defca