1967707 - Expose error messaging when submitting invalid cookies

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, enhancement, P2)

Description

[Andrea Marchesini [:baku]]

Soon (bug 1955685), we’ll improve cookie validation to prevent storing invalid cookies. Currently, validation errors are only logged via console.error(), but it would be better to surface them through a UI component so users can see and fix issues while editing.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

We're already doing this when deleting IndexedDB databases in https://searchfox.org/mozilla-central/rev/dbef1a2f75798fb0136b7428d959c8feb09ad5d1/devtools/client/storage/ui.js#1697-1711

const result = await front.removeDatabase(host, dbName);
if (result.blocked) {
  const notificationBox = this._toolbox.getNotificationBox();
  const message = await this._panelDoc.l10n.formatValue(
    "storage-idb-delete-blocked",
    { dbName }
  );

  notificationBox.appendNotification(
    message,
    "storage-idb-delete-blocked",
    null,
    notificationBox.PRIORITY_WARNING_LOW
  );
}

so it's using the notification box, and here we could have a higher priority

Comment 2

[Julian Descottes [:jdescottes]]

Given that Bug 1955685 is now fixed, we should triage this.

Baku: I don't have access to the blocking bug (not sure if anyone in the team can?). Can you share some examples of invalid cookie values?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Note that I have a patch ready for this (my moz-phab is busted though, need to fix it so I can push my patch to Phab)
To have an invalid cookie, you can add one from the storage panel, and then edit its name, adding a space before it

Comment 4

[Andrea Marchesini [:baku]]

Here is a list of steps to create invalid cookies via devtools:

• a cookie with a name (or value) starting or ending with spaces
• a cookie with some invalid chars
• mark a cookie as non-secure but with sameSite=none

https://searchfox.org/mozilla-central/rev/bd57b566959758d0455c6e37afca00648c8e4ff0/devtools/server/actors/resources/storage/cookies.js#570-573 - here is where the validation error is generated. The string is currently not localized. We can easily generate a localized one via a new attribute/method. I can work on that bit if needed.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1967707 - [devtools] Display error message when submitting invalid cookies. r=#devtools

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6fb5debd791d
https://hg.mozilla.org/integration/autoland/rev/2408bee8bcc4
[devtools] Display error message when submitting invalid cookies. r=devtools-reviewers,fluent-reviewers,devtools-backward-compat-reviewers,jdescottes,bolsson

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2408bee8bcc4