1967810 - Fix offthread baseline compilation

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[Iain Ireland [:iain]]

While working on bug 1960433, I've uncovered a number of latent issues in the initial implementation of offthread baseline compilation.

Comment 1

[Iain Ireland [:iain]]

Attachment: Bug 1967810: Call ensureExecutionObservabilityOfOsrFrame in OSREntryForFrame r=jandem

RecompileBaselineScriptForDebugMode is normally enough here, but there are some corner cases where it's insufficient. In particular, if we already have an IonScript at this point, we need to invalidate it before replacing the baseline script, to preserve our invariants about BaselineScript implying IonScript. Looking at the code that calls RecompileBaselineScriptForDebugMode, there's enough complexity that it seems better to reproduce the existing approach more precisely. This requires converting OSREntryForFrame into a VM call.

This path now more closely matches the existing path in CanEnterBaselineJIT.

Comment 2

[Iain Ireland [:iain]]

Attachment: Bug 1967810: Fix BaselineQueuedScriptPtr r=jandem

Comment 3

[Iain Ireland [:iain]]

Attachment: Bug 1967810: Don't look at function flags in baseline compiler r=jandem

TSAN doesn't like it when we look at function flags offthread.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03a954bf8c9f
Call ensureExecutionObservabilityOfOsrFrame in OSREntryForFrame r=jandem
https://hg.mozilla.org/integration/autoland/rev/0865222c28a0
Fix BaselineQueuedScriptPtr r=jandem
https://hg.mozilla.org/integration/autoland/rev/e3faaea247b6
Don't look at function flags in baseline compiler r=jandem
https://hg.mozilla.org/integration/autoland/rev/4c020f44c7c3
apply code formatting via Lando

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/03a954bf8c9f
https://hg.mozilla.org/mozilla-central/rev/0865222c28a0
https://hg.mozilla.org/mozilla-central/rev/e3faaea247b6
https://hg.mozilla.org/mozilla-central/rev/4c020f44c7c3