Closed Bug 1967813 Opened 11 months ago Closed 11 months ago

Assertion hit when querying popup menu's state

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
141 Branch
Tracking Flags:
Tracking Status
firefox140 --- wontfix
firefox141 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1967813 - Check menu's frame IsOpen to determine if menu is active. r=morgan
48 bytes, text/x-phabricator-request
Details | Review

If you open a context menu and then query the state of the menu you hit this assertion: "XULMenupopup doesn't have INVISIBLE when it's inactive"

Looks like the element hierarchy has changed a bit since this was first introduced. We also don't ever query for the menu's state in our tests so this was never tripped.

Assignee: nobody → eitan
Status: NEW → ASSIGNED
Severity: -- → S4
Blocks: 1899960
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8b8845950a35 Check menu's frame IsOpen to determine if menu is active. r=morgan

https://hg.mozilla.org/mozilla-central/rev/8b8845950a35

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox140: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae9af3d98823 Check menu's frame IsOpen to determine if menu is active. r=morgan

Backed out for causing junit failures.

Please also check these Android Components Ui tests failures. Failure log.

Flags: needinfo?(eitan)
QA Whiteboard: [qa-triage-done-c141/b140]
Attachment #9489731 - Flags: approval-mozilla-beta?
Flags: needinfo?(eitan)
Attachment #9489731 - Flags: approval-mozilla-beta?
Attachment #9489731 - Flags: approval-mozilla-beta?
Attachment #9489731 - Attachment is obsolete: true
Attachment #9489731 - Flags: approval-mozilla-beta?
Attachment #9491792 - Attachment description: Bug 1967813 - Check menu's frame IsOpen to determine if menu is active. r?me → Bug 1967813 - Check menu's frame IsOpen to determine if menu is active. r=morgan

Backed out fir causing ba failures

Backout link

Push with failures

Failure log

This was backed out

Status: RESOLVED → REOPENED
status-firefox140: fixed → affected
Resolution: FIXED → ---
Target Milestone: 140 Branch → ---

Reverted this because it was causing mochitests failures in browser_simplePatterns.js.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | accessible/tests/browser/windows/uia/browser_simplePatterns.js | Uncaught exception in test bound uiaTask - at chrome://mochitests/content/browser/accessible/tests/browser/shared-head.js:1084 - Error: Traceback (most recent call last):
Flags: needinfo?(eitan)

https://hg.mozilla.org/mozilla-central/rev/dfa9294b1d30

Status: REOPENED → RESOLVED
Closed: 11 months ago → 11 months ago
status-firefox141: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 141 Branch
Flags: needinfo?(eitan)
Summary: Assertion hit when uerying popup menu's state → Assertion hit when querying popup menu's state
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: