1967831 - Some cleanup and refactor for ChannelMediaDecoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P2)

Description

[Alastor Wu [:alwu]]

We will need to do some cleanup and refactor first, before solving the problem in bug 1967092.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1967831 - part1 : remove unused function GetRateAtLastStop().

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1967831 - part2 : merge ComputePlaybackRate() and UpdatePlaybackRate().

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1967831 - part3 : move MediaStatistics into ChannelMediaDecoder.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1967831 - part4 : add more logs for ChannelMediaDecoder.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1967831 - part5 : rename mPlaybackPosition to mPlaybackByteOffset.

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1967831 - part6 : remove GetStatistics() and renames MediaStatistics variables.

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1967831 - part7 : make MediaChannelStatistics thread-safe.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ea909821271
part1 : remove unused function GetRateAtLastStop(). r=media-playback-reviewers,karlt
https://hg.mozilla.org/integration/autoland/rev/0d08f5cbdf72
part2 : merge ComputePlaybackRate() and UpdatePlaybackRate(). r=media-playback-reviewers,karlt
https://hg.mozilla.org/integration/autoland/rev/70633955e6bc
part3 : move MediaStatistics into ChannelMediaDecoder. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/c4d443768bf2
part4 : add more logs for ChannelMediaDecoder. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/47db8f652629
part5 : rename mPlaybackPosition to mPlaybackByteOffset. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/fab5e542a4e9
part6 : remove GetStatistics() and renames MediaStatistics variables. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/f115341d07d1
apply code formatting via Lando

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1ea909821271
https://hg.mozilla.org/mozilla-central/rev/0d08f5cbdf72
https://hg.mozilla.org/mozilla-central/rev/70633955e6bc
https://hg.mozilla.org/mozilla-central/rev/c4d443768bf2
https://hg.mozilla.org/mozilla-central/rev/47db8f652629
https://hg.mozilla.org/mozilla-central/rev/fab5e542a4e9
https://hg.mozilla.org/mozilla-central/rev/f115341d07d1