1967963 - [wpt-sync] Sync PR 52723 - Add length conversion checkers to CSSRotateInterpolationType

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52723 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52723
Details from upstream follow.

Daniil Sakhapov <[e-mail]> wrote:

Add length conversion checkers to CSSRotateInterpolationType

So that when the font-size changes during animation, we correctly
update the relative-units dependent value.

Bug: 415572412
Change-Id: I8e24abc9d303bbcbb09120b9e49e49eba657938a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578329
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Commit-Queue: Daniil Sakhapov \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1463998}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 52723 applied with additional changes from upstream: dee11aa747c260ab3966d8e89813ace1fc1df879

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=67f68d547071f462d73a20ef6d3d0ceff65759b4

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
PASS: 1
FAIL: 1

Safari

OK : 1
PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /css/css-values/sign-in-keyframes-with-relative-units.html [wpt.fyi]
  • Initially, the font-size is 8px for #target, so the result is 0.75: FAIL linked bug:Bug 1967970

New Tests That Don't Pass

• /css/css-values/sign-in-keyframes-with-relative-units.html [wpt.fyi]
  • Initially, the font-size is 8px for #target, so the result is 0.75: FAIL (Chrome: PASS, Safari: PASS)
  • Changing the font-size of #target changes the start point, so the result should be 1.75: FAIL (Chrome: FAIL, Safari: PASS)

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1967963 [wpt PR 52723] - Add length conversion checkers to CSSRotateInterpolationType, a=testonly

Automatic update from web-platform-tests
Add length conversion checkers to CSSRotateInterpolationType

So that when the font-size changes during animation, we correctly
update the relative-units dependent value.

Bug: 415572412
Change-Id: I8e24abc9d303bbcbb09120b9e49e49eba657938a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578329
Reviewed-by: Anders Hartvoll Ruud <[e-mail]>
Commit-Queue: Daniil Sakhapov <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1463998}

--

wpt-commits: 250eb25aea158b631814b75e109f88404441cdb8
wpt-pr: 52723

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/201f0f558fa1
[wpt PR 52723] - Add length conversion checkers to CSSRotateInterpolationType,

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/201f0f558fa1