Closed
Bug 1968038
Opened 10 months ago
Closed 2 months ago
Make it more clear that bergamot-translator.js is generated code
Categories
(Firefox :: Translations, task)
Firefox
Translations
Tracking
()
RESOLVED
FIXED
149 Branch
| Tracking | Status | |
|---|---|---|
| firefox149 | --- | fixed |
People
(Reporter: nordzilla, Assigned: tetchart)
Details
Attachments
(1 file)
Description
It isn't very clear currently, within the bergamot-translator.js file itself, that this code is generated in our https://github.com/mozilla/translations repository and pulled into tree.
We should update the build-bergamot.py script to insert a comment that expresses that the code in this file is generated.
|
Assignee | |
Updated•2 months ago
|
Assignee: enordin → tetchart
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•2 months ago
|
||
Created a PR for this: https://github.com/mozilla/translations/pull/1359
|
|
Assignee | |
Comment 2•2 months ago
|
||
|
|
Assignee | |
Comment 3•2 months ago
|
||
PR completed. Submitted to phab for vendoring in the change: https://phabricator.services.mozilla.com/D280504
|
||
Updated•2 months ago
|
Attachment #9540198 -
Attachment description: WIP: Bug 1968038 - updated translations repo hash to vender in autogenerated comment. Fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1968038 → Bug 1968038 - updated translations repo hash to vender in autogenerated comment
Pushed by enordin@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/48d55cf7ec80
https://hg.mozilla.org/integration/autoland/rev/ab91df22f920
updated translations repo hash to vender in autogenerated comment r=nordzilla,translations-reviewers
|
||
Comment 5•2 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox149:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
|
||
Updated•1 month ago
|
QA Whiteboard: [qa-triage-done-c150/b149]
You need to log in
before you can comment on or make changes to this bug.
Description
•