Closed Bug 196814 Opened 21 years ago Closed 21 years ago

manual proxies in pref window, should check if the prefs is locked.

Categories

(SeaMonkey :: Preferences, defect)

Product:
SeaMonkey
Component:
Preferences
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: yinbolian, Assigned: yinbolian)

References

Details

Attachments

(1 file, 1 obsolete file)

patch_for_checkin (with neil's comments)
1.47 KB, patch
Details | Diff | Splinter Review 
If the prefs for manual proxies and their ports are locked, the widgets should
be disabled.
Attached patch patch (obsolete) — — Splinter Review 

    
  

        Attachment #116837 -
        Flags: review?(dbragg)

    
  

        Attachment #116837 -
        Flags: review?(dbragg) → review?(ben)

    
  
Blocks: 195708
Status: NEW → ASSIGNED

    
    

    
  
I would not ask ben if you want a review anytime soon, I suggest asking
jaggernaut@netscape.com for review...

    
  

        Attachment #116837 -
        Flags: review?(ben) → review?(jaggernaut)

    
    

    
  
Comment on attachment 116837 [details] [diff] [review]
patch

sr=jag

        Attachment #116837 -
        Flags: superreview+

        Attachment #116837 -
        Flags: review?(neil)

        Attachment #116837 -
        Flags: review?(jaggernaut)

    
    

    
  
Comment on attachment 116837 [details] [diff] [review]
patch

I can't test this for locked preferences, though...

        Attachment #116837 -
        Flags: review?(neil) → review+

    
    

    
  
Comment on attachment 116837 [details] [diff] [review]
patch

I've just noticed a duplicate declaration of prefstring - you'd better fix that
before you check in.

    
    

    
  


  

        Attachment #116837 -
        Attachment is obsolete: true

    
    

    
  
Checked in Trunk.  Thanks.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED

    
    

    
  
vrfy'd fixed with 2003.04.02 comm trunk builds, all platforms.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: