1968158 - "Open in New Container Tab" can open outside of a tab group

Status: NEW

(Firefox :: Tabbed Browser, defect, P3)

Description

[Stephen Thompson [:sthompson]]

This is an interaction between tab groups and the multi-account containers extension. So to reproduce, that extension will need to be installed, and some site (say, containersite.com) needs to be configured to always open in a particular container.

Steps to reproduce:

1. Open a tab to test with
2. Right-click the tab and choose "Add Tab to New Group" to create a tab group containing that tab.
3. Right-click the tab, hover over "Open in New Container Tab," and click one of the containers (e.g. Personal)

Expected behavior: a new tab with the same URL of the test tab should open next to the test tab. The new tab should be in the same tab group as the test tab.
Observed behavior: a new tab with the same URL of the test tab opens next to the test tab, but the new tab is not in any tab group.

The tab context menu is wired up from https://searchfox.org/mozilla-central/rev/e66fea62620cd4d77242764f9b09c91ae1040e1d/browser/base/content/main-popupset.js#414 which then calls Tabbrowser.addTab without any tab group context https://searchfox.org/mozilla-central/rev/e66fea62620cd4d77242764f9b09c91ae1040e1d/browser/components/tabbrowser/content/tabbrowser.js#9259-9264 The addTab call should receive the tab group context for each of the contextTabs so that the new tabs will go into tab groups where appropriate.