1968244 - The "Expand sidebar on hover" option is not kept after the vertical tabs are disabled and enabled again

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P3)

Description

[Oana Botisan, Desktop QA]

Found in

• Nightly 140.0a1

Affected versions

• Firefox 139.0
• Nightly 140.0a1

Tested platforms

• Affected platforms: Windows 11, macOS 13

Steps to reproduce

1. Go to about:preferences#general
2. Enable "Vertical tabs" from Browser Layout
3. Right-click on the tabs > Customize Sidebar
4. Select "Expand sidebar on hover".
5. Enable "Horizontal tabs" and then "Vertical tabs" again.

Expected result

• The "Expand sidebar on hover" option is still enabled.

Actual result

• The "Expand sidebar on hover" option is NOT enabled.

Regression range

• Not sure if this is a regression. If there is one I will find it asap.

Note

• The same thing happens if the size of the Sidebar is changed.

Comment 1

[Oana Botisan, Desktop QA]

This is not a regression. I can reproduce this issue on the first build that the Bug 1953155 - Enable expand on hover option and remove expand on hover coming soon message, was implemented.

Comment 2

[DrSeed]

Hello kcochrane: nikkis: sfoster:

Please can I work on this bug?

Comment 3

[Nikki Sharpley (:nikkis) (she/her)]

Hi DrSeed, absolutely! This one may be more challenging so be sure to reach out if you need guidance. We likely will need a way to store the previous expand on hover selected state.

Comment 4

[DrSeed]

Attachment: Bug 1968244 - Persist expand-on-hover visibility r=nsharpley

When vertical tabs are disabled, the sidebar visibility setting
(such as'expand-on-hover') was being discarded and unconditionally
replaced with'always-show' when vertical tabs were re-enabled.
Save the current visibility setting before overwriting it
with'hide-sidebar' when vertical tabs are disabled, and restore it
whenvertical tabs are re-enabled. Add a test to verify the behaviour.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2e7b53d8446a
https://hg.mozilla.org/integration/autoland/rev/a6596200068b
Persist expand-on-hover visibility r=kcochrane

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a6596200068b