1968257 - Netmonitor crashed (null JSON response)

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Alexandre Poirot [:ochameau]]

It crashed when uploading an image on https://www.leboncoin.fr/deposer-une-annonce
and inspector the PUT request.

Error in Network:

TypeError: can't access property "type", json is null

React Component Stack:

in ResponsePanel
in div
in TabPanel
in div
in div
in div
in Tabs
in Sidebar
in div
in Tabbar
in TabboxPanel
in Connect(TabboxPanel)
in div
in NetworkDetailsBar
in Connect(NetworkDetailsBar)
in div
in div
in SplitBox
in div
in MonitorPanel
in Connect(MonitorPanel)
in div
in DropHarHandler
in AppErrorBoundary
in div
in App
in Connect(App)
in Provider
in LocalizationProvider
in Provider

Stacktrace:

parseJSON@resource://devtools/client/netmonitor/src/utils/request-utils.js:743:21
UNSAFE_componentWillReceiveProps@resource://devtools/client/netmonitor/src/components/request-details/ResponsePanel.js:130:39
callComponentWillReceiveProps@resource://devtools/client/shared/vendor/react-dom.mjs:8302:14
updateClassInstance@resource://devtools/client/shared/vendor/react-dom.mjs:8478:36
updateClassComponent@resource://devtools/client/shared/vendor/react-dom.mjs:10595:20
beginWork@resource://devtools/client/shared/vendor/react-dom.mjs:11415:16
performUnitOfWork@resource://devtools/client/shared/vendor/react-dom.mjs:14698:12
workLoop@resource://devtools/client/shared/vendor/react-dom.mjs:14716:24
renderRoot@resource://devtools/client/shared/vendor/react-dom.mjs:14799:15
performWorkOnRoot@resource://devtools/client/shared/vendor/react-dom.mjs:15651:17
performWork@resource://devtools/client/shared/vendor/react-dom.mjs:15563:24
performSyncWork@resource://devtools/client/shared/vendor/react-dom.mjs:15537:14
requestWork@resource://devtools/client/shared/vendor/react-dom.mjs:15406:5
scheduleWork@resource://devtools/client/shared/vendor/react-dom.mjs:15220:16
enqueueSetState@resource://devtools/client/shared/vendor/react-dom.mjs:8188:17
Component.prototype.setState@resource://devtools/client/shared/vendor/react.mjs:322:16
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1412:16
notify@resource://devtools/client/shared/vendor/react-redux.js:1159:21
notifyNestedSubs@resource://devtools/client/shared/vendor/react-redux.js:1198:20
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1409:16
visibilityHandlerStore/subscribe/unsubscribe<@resource://devtools/client/shared/redux/visibilityHandlerStore.js:43:11
dispatch@resource://devtools/client/shared/vendor/redux.js:265:7
waitUntilService/</<@resource://devtools/client/shared/redux/middleware/wait-service.js:59:24
eventTelemetryMiddleware/</</<@resource://devtools/client/netmonitor/src/middleware/event-telemetry.js:29:21
throttlingMiddleware/</</<@resource://devtools/client/netmonitor/src/middleware/throttling.js:18:21
flushActions@resource://devtools/client/netmonitor/src/middleware/batching.js:88:11
DelayedTask/this._promise</this.runTask@resource://devtools/client/netmonitor/src/middleware/batching.js:107:9
notify@resource://gre/modules/Timer.sys.mjs:66:16

Comment 1

[Julian Descottes [:jdescottes]]

recent regression from JSON_NUMBER changes

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1968257 - [devtools] Fix Netmonitor response panel crash on null JSON response. r=#devtools

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1965996

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a717a0c2be91
[devtools] Fix Netmonitor response panel crash on null JSON response. r=devtools-reviewers,jdescottes

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a717a0c2be91

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox140 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1968257 - [devtools] Fix Netmonitor response panel crash on null JSON response. r=#devtools

Original Revision: https://phabricator.services.mozilla.com/D251555

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: DevTools Network panel might crash when the user inspects a Response
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: -
• Risk associated with taking this patch: low
• Explanation of risk level: DevTools only, adding a guard, covered by automated test
• String changes made/needed: -
• Is Android affected?: no

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/bc8ea6d91ed3
https://hg.mozilla.org/releases/mozilla-beta/rev/800ae3ebf122