1968267 - Copying and pasting text from Microsoft Word creates a broken character

Status: RESOLVED WORKSFORME

(Core :: Widget: Win32, defect)

Description

[Selim Şumlu]

Attachment: paste-from-word.jpg

Steps to reproduce

1. Copy any text from Microsoft Word. (I'm using the latest version: 2504)
2. Paste into the Firefox location bar or any form field.

Result

A broken character appears at the end of the copied text. See the screenshot attached.

I'm using the latest Nightly on Windows 11 and I can reproduce this on troubleshoot mode. I believe this issue has appeared in the past few days. I cannot reproduce this when copying from Notepad or any other Office apps. It's just Word.

Comment 1

[Edgar Chen [:edgar] (OOO untils 09/01, slow response)]

(In reply to Selim Şumlu from comment #0)

I believe this issue has appeared in the past few days. I cannot reproduce this when copying from Notepad or any other Office apps. It's just Word.

Thanks for reporting this issue.
Is it possible that you can help to run mozregression to find the regression window?

Comment 2

[Selim Şumlu]

Differential Revision: https://phabricator.services.mozilla.com/D249702

pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d74aee22f0ac3d2462dc623d35274e5701e054e1&tochange=a7594596cdb1b28f26589d2a1113f767837ac2b0

Comment 3

[Jan Jaeschke [:jjaschke]]

Thanks! David, could you take a look?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1966443

Comment 5

[David Parks [:handyman]]

Looking at it now.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1966443

Comment 7

[David Parks [:handyman]]

Attachment: Bug 1968267: Ignore 0x0 0xa combination at end of clipboard text r=#win-reviewers!

Word inserts a stray line feed (0x000a) at the end of strings. Sometimes,
it is preceeded by a null character (0x0000 0x000a). Sometimes the null
character follows the LF (0x000a 0x0000). Line breaks are added as LF-CR
(0x000a 0x000d) and are therefore not removed here.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/074b407a4761
Ignore stray line feeds at end of clipboard text r=win-reviewers,gstoll

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84f820e2dd3e
Revert "Bug 1968267: Ignore stray line feeds at end of clipboard text r=win-reviewers,gstoll" for causing multiple failures "clipboard" related

Comment 10

[Cristian Tuns]

Backed out for causing multiple failures "clipboard" related

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_bug830600.html | Timed out while polling clipboard for requested data, got:
• https://treeherder.mozilla.org/logviewer?job_id=510288094&repo=autoland
  TEST-UNEXPECTED-FAIL | toolkit/components/aboutwindowsmessages/tests/browser/browser_aboutwindowsmessages.js | should copy the right number of lines to the clipboard - 19 == 20 -

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox140 (beta) and tracked for firefox141 (nightly). However, the bug still has low severity.

:hsinyi, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 12

[David Parks [:handyman]]

Instead of trying to do something consistent, which causes the kinds of errors seen in the test failures, we'll just keep the one-character-null removal from before and also ignore 0x0000 0x000a nonsense strings at the end of the buffer. This would not do the "right" thing with every copy from Word but it should do the right thing in most cases and not break clipboard copies from applications that don't have the Word bug. The failure case is copying just one line break from Word -- it copies that as 0x0000 0x000a, which we will obviously reduce to nothing. Two line breaks are copied as 000d 000a 000d 000a 0000, which gets properly pasted as two line breaks. FTR, Edge and Chrome do the same thing -- a copy of one line break is reduced to nothing.

Comment 13

[David Parks [:handyman]]

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=ON5oOZ8-RL6Fn50nY_aIYw.0&tier=1%2C2%2C3&revision=e81958c4effa235f50f6cf8dd0ddba4a788a86b1

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e422931fd17b
Ignore 0x0 0xa combination at end of clipboard text r=win-reviewers,gstoll

Comment 15

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e422931fd17b

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:handyman, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox140 to wontfix.

For more information, please visit BugBot documentation.

Comment 17

[David Parks [:handyman]]

Comment on attachment 9491053 [details]
Bug 1968267: Ignore 0x0 0xa combination at end of clipboard text r=#win-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Pastes of copies from Word will have an extra nonsense byte appended.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): At most, the patch removes a couple of bytes from the paste.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9491053 [details]
Bug 1968267: Ignore 0x0 0xa combination at end of clipboard text r=#win-reviewers!

Approved for 140.0b4.

Comment 19

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/140ce197d1e0
https://hg.mozilla.org/releases/mozilla-beta/rev/9603f25dbc86

Comment 20

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/62baff5750e7
https://hg.mozilla.org/releases/mozilla-beta/rev/4c7515ab2bc2

Comment 21

[Donal Meehan [:dmeehan]]

Backed out from beta, as part of backing out the regressor Bug 1966443

Comment 22

[agoloman]

Backed out from autoland: https://github.com/mozilla-firefox/firefox/commit/4cbd07eea6ce

Comment 23

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1966443

Comment 24

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:handyman, could you have a look please?

For more information, please visit BugBot documentation.

Comment 25

[David Parks [:handyman]]

Fixed by regressor backout.