Open Bug 1968277 Opened 1 year ago Updated 1 year ago

scriptworker config schemas should be checked at runtime

Categories

(Release Engineering :: Release Automation, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: bhearsum, Unassigned, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=py])

Many of our scriptworkers have config schema files. These are consumed in tests, with fake data used to render the config from the json-e, but we never validate the actual production versions of these configs AFAICT.

My suggestion to fix this is to update configloader with support for taking a schema, and having it validate the schema after rendering.

An alternative would be to update scriptworker_client and scriptworker.client config loading to do it. On top of needing to update both places, it also seems preferable to validate the config before the script is called? I could be convinced otherwise though.

Mentor: bhearsum
You need to log in before you can comment on or make changes to this bug.