Closed Bug 1968284 Opened 2 months ago Closed 2 months ago

Refactor Marionette unit tests using chrome windows and update related chrome assets

Categories

(Remote Protocol :: Marionette, task, P2)

Product:
Remote Protocol
Component:
Marionette
Type:
task
Points:
3

Tracking

(firefox141 fixed)

Status:
RESOLVED FIXED
Milestone:
141 Branch
Tracking Flags:
Tracking Status
firefox141 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [webdriver:m16])

Attachments

(1 file)

Bug 1968284 - [marionette] Refactor unit tests using chrome windows and update related chrome assets.
48 bytes, text/x-phabricator-request
Details | Review

Before uploading a patch for bug 1344267 I would like to refactor all of the Marionette unit tests that are using the in chrome:// registered test window. It's also reducing the number of those chrome assets to make it easier to convert everything.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Points: --- → 3
Priority: -- → P2
Whiteboard: [webdriver:m16]
Pushed by hskupin@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e5302f602e85 https://hg.mozilla.org/integration/autoland/rev/ecc02f01bd62 [marionette] Refactor unit tests using chrome windows and update related chrome assets. r=webdriver-reviewers,jdescottes
Pushed by nfay@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/78ce233aed90 https://hg.mozilla.org/integration/autoland/rev/f8715d6aacd5 Revert "Bug 1968284 - [marionette] Refactor unit tests using chrome windows and update related chrome assets. r=webdriver-reviewers,jdescottes" for causing bc failures on browser_all_files_referenced.js

Backed out for causing bc failures on browser_all_files_referenced.js

Backout link

Push with failures

Failure log

Flags: needinfo?(hskupin)

The failure here is unreferenced file: chrome://remote/content/marionette/test_dialog.properties. I explicitly added this bundle to test_dialog.xhtml but it looks like that a stringbundle doesn't count here. I'm going to re-add test_dialog.properties for now.

Flags: needinfo?(hskupin)
Pushed by hskupin@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5259d13e8ca0 https://hg.mozilla.org/integration/autoland/rev/5d5d84c3cecb [marionette] Refactor unit tests using chrome windows and update related chrome assets. r=webdriver-reviewers,jdescottes

https://hg.mozilla.org/mozilla-central/rev/5d5d84c3cecb

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox141: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 141 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: