1968303 - Fix a ruff warning in js/src/jit/GenerateABIFunctionType.py

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

js/src/jit/GenerateABIFunctionType.py
72:12: warning Consider merging multiple comparisons: `arg in {"Float32", "Float64"}`. PLR1714 (ruff)

Link to the code:
https://searchfox.org/mozilla-central/source/js/src/jit/GenerateABIFunctionType.py#72
To run the linter:

./mach lint -W -l ruff js/src/jit/GenerateABIFunctionType.py

As the change is trivial, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[viet-hung.nhu]

Attachment: Bug 1968303 - ruff: fix repeated equality comparison r=sylvestre

Comment 2

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:viet-hung.nhu, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9fc6ead1de1e
https://hg.mozilla.org/integration/autoland/rev/273840efe285
ruff: fix repeated equality comparison r=sylvestre

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/273840efe285