1968325 - Remove Pocket suggestions from the `suggest` component

Status: RESOLVED FIXED

(Application Services :: Suggest, task, P3)

Description

[Drew Willcoxon :adw]

We should remove Pocket suggestions from the suggest component in application-services. There's not a single place or module where they live but this code search should cover everything.

Bug 1959497 is the corresponding desktop bug.

Once that's merged into app-services, we'll need to vendor into m-c, which should have a separate bug filed for it. Vendoring steps:

1. Update Cargo.toml so the application-services components use the new revision

2. In a full (non-artifact) build, run:

./mach vendor rust
./mach uniffi generate

Vendoring docs here: 1, 2

3. Upload the resulting patch to phabricator like usual

Comment 1

[kpatenio]

WIP pull request for application-services can be found here: https://github.com/mozilla/application-services/pull/6770

Comment 2

[Becca]

Attachment: WIP: Bug 1968325 - Remove Pocket suggestions from the suggest component

Comment 3

[Drew Willcoxon :adw]

Thanks for your effort to vendor here Becca, sorry for the trouble. As we found out, vendoring is broken on Windows (bug 1938341), so I'll go ahead and take that on. We typically file a new bug for each vendoring, so I'll do that and link it here. This bug tracks the Rust changes that kpatenio made, so I'll set this bug's assignee appropriately and close it since kpatenio's PR has been merged.