1968366 - [wpt-sync] Sync PR 52765 - Allow computed column-rule serialization consistent with specified one

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52765 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52765
Details from upstream follow.

Sam Davis Omekara Jr. <[e-mail]> wrote:

Allow computed column-rule serialization consistent with specified one

This CL adds the "skip default/initial value" behavior for the computed
column-rule serialization to match the shortest serialization principle
(similar to crrev.com/c/6563724). This behavior was already implemented
for the specified shorthand 1, so this CL allows that same behavior to
apply to the computed value as well. This should fix the RoundTrip error
for column-rule, which reduces the number of broken properties in
"CSSParserImplTest, AllPropertiesCanParseImportant" test.

Bug: 338535751
Change-Id: I07eb472b2bc1f7cd210d49c22791098a77fde63d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6576943
Commit-Queue: Sam Davis Omekara \<[e-mail]>
Reviewed-by: Kevin Babbitt \<[e-mail]>
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1465029}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3624ec774bb06fbfb777da2bae47e98990c4a3fb

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Safari on GitHub CI

Total 2 tests and 6 subtests

Status Summary

Firefox

OK : 2
PASS: 7
FAIL: 2

Safari

OK : 2
PASS: 6
FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-multicol/parsing/column-rule-computed.html [wpt.fyi]
  • Property column-rule value '10px': FAIL (Safari: FAIL)
  • Property column-rule value '0px none rgb(255, 0, 255)': FAIL (Safari: FAIL)

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1968366 [wpt PR 52765] - Allow computed column-rule serialization consistent with specified one, a=testonly

Automatic update from web-platform-tests
Allow computed column-rule serialization consistent with specified one

This CL adds the "skip default/initial value" behavior for the computed
column-rule serialization to match the shortest serialization principle
(similar to crrev.com/c/6563724). This behavior was already implemented
for the specified shorthand 1, so this CL allows that same behavior to
apply to the computed value as well. This should fix the RoundTrip error
for column-rule, which reduces the number of broken properties in
"CSSParserImplTest, AllPropertiesCanParseImportant" test.

Bug: 338535751
Change-Id: I07eb472b2bc1f7cd210d49c22791098a77fde63d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6576943
Commit-Queue: Sam Davis Omekara <[e-mail]>
Reviewed-by: Kevin Babbitt <[e-mail]>
Reviewed-by: Anders Hartvoll Ruud <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1465029}

--

wpt-commits: 8389d8b9d31d90386a6499bfe288fd7366e40462
wpt-pr: 52765

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1968366 [wpt PR 52765] - Update wpt metadata, a=testonly

wpt-pr: 52765
wpt-type: metadata

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaeb2807418f
[wpt PR 52765] - Allow computed column-rule serialization consistent with specified one,
https://hg.mozilla.org/integration/autoland/rev/c8ab0bcfb226
[wpt PR 52765] - Update wpt metadata,

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/aaeb2807418f
https://hg.mozilla.org/mozilla-central/rev/c8ab0bcfb226