1968504 - [wpt-sync] Sync PR 52778 - shape(): support arc radius direction-agnostic size

Status: RESOLVED FIXED

(Core :: Web Painting, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 52778 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52778
Details from upstream follow.

Noam Rosenthal <[e-mail]> wrote:

shape(): support arc radius direction-agnostic size

Spec: https://drafts.csswg.org/css-shapes-2/#direction-agnostic-size

When an arc() value receives only one argument for a radius, compute
percentages for this radius as "direction-agnostic size", i.e. a
percentage from the diagonal length, creating a circular arc.

Implemented behind a flag as it is a change to a shipped feature.

At this point this would interpolate incorrectly, will fix interpolation
in a followup CL, so the interpolation tests that test this are
converted to use both radii for now. (this bug exists for WebKit as
well, so removing these tests will not regress anything there).

R=[e-mail]

Bug: 417852973
Change-Id: I0baafefb5b33ede1a5a949b6f9be92e6480f456b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6573335
Commit-Queue: Noam Rosenthal \<[e-mail]>
Reviewed-by: Fredrik Söderquist \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1465464}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e7dfead9e1aa525d798a69f046775b7539aea9b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 35 subtests

## Status Summary

### Firefox
`OK`  : 5
`PASS`: 1027
`FAIL`: 345

### Chrome
`OK`  : 5
`PASS`: 1366
`FAIL`: 6

### Safari
`OK`  : 5
`PASS`: 1366
`FAIL`: 6

## Links
[GitHub PR Head](https://wpt.fyi/results/?sha=5fcef72829700d8b96871eaae464d6e083f28b64&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=5fcef72829700d8b96871eaae464d6e083f28b64&label=pr_base)

## Details

(See attachment for full changes)

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1968504 [wpt PR 52778] - shape(): support arc radius direction-agnostic size, a=testonly

Automatic update from web-platform-tests
shape(): support arc radius direction-agnostic size

Spec: https://drafts.csswg.org/css-shapes-2/#direction-agnostic-size

When an arc() value receives only one argument for a radius, compute
percentages for this radius as "direction-agnostic size", i.e. a
percentage from the diagonal length, creating a circular arc.

Implemented behind a flag as it is a change to a shipped feature.

At this point this would interpolate incorrectly, will fix interpolation
in a followup CL, so the interpolation tests that test this are
converted to use both radii for now. (this bug exists for WebKit as
well, so removing these tests will not regress anything there).

R=[e-mail]

Bug: 417852973
Change-Id: I0baafefb5b33ede1a5a949b6f9be92e6480f456b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6573335
Commit-Queue: Noam Rosenthal <[e-mail]>
Reviewed-by: Fredrik Söderquist <[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1465464}

--

wpt-commits: 995a8e17bb74e2c1e46f3698fb9ee94a69a5f3ef
wpt-pr: 52778

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1968504 [wpt PR 52778] - Update wpt metadata, a=testonly

wpt-pr: 52778
wpt-type: metadata

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2b64c606ff69
https://hg.mozilla.org/integration/autoland/rev/2483426e775d
[wpt PR 52778] - shape(): support arc radius direction-agnostic size,
https://github.com/mozilla-firefox/firefox/commit/a02efde0d060
https://hg.mozilla.org/integration/autoland/rev/8cf2c27d73bc
[wpt PR 52778] - Update wpt metadata,

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2483426e775d
https://hg.mozilla.org/mozilla-central/rev/8cf2c27d73bc