Closed Bug 1968561 Opened 9 months ago Closed 9 months ago

Switch Mac signing to new M2 Mac signers

Categories

(Release Engineering :: General, task, P2)

Tracking

(firefox-esr115 verified, firefox-esr128 verified, firefox-esr140 verified, firefox141 verified)

VERIFIED FIXED
Tracking Status
firefox-esr115 --- verified
firefox-esr128 --- verified
firefox-esr140 --- verified
firefox141 --- verified

People

(Reporter: hneiva, Assigned: hneiva)

References

Details

Attachments

(5 files)

No description provided.
Pushed by hneiva@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/97f05637a92e Switch Mac signing to new M2 Mac Signer pool r=releng-reviewers,ahal
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Pushed by smolnar@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/9944947d9b28 Revert "Bug 1968561 - Switch Mac signing to new M2 Mac Signer pool r=releng-reviewers,ahal" missing scopes for central/main and causing the decision task to fail

Backed out for missing scopes for central/main and causing the decision task to fail

Backout link: https://hg.mozilla.org/mozilla-central/rev/9944947d9b28311bb247894425f91b984eecbf3b

Status: RESOLVED → REOPENED
Flags: needinfo?(hneiva)
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 9 months ago9 months ago
Flags: qe-verify+
Resolution: --- → FIXED
Pushed by hneiva@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/37089ba72498 Switch Mac signing to new M2 Mac Signer pool r=releng-reviewers,ahal
Flags: needinfo?(hneiva)
Attachment #9499575 - Flags: approval-mozilla-esr140?
Attachment #9499576 - Flags: approval-mozilla-esr128?
Attachment #9499577 - Flags: approval-mozilla-esr115?

firefox-esr140 Uplift Approval Request

  • User impact if declined: Eventually we won't be able to sign
  • Code covered by automated testing: no
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: Make sure the browser launches in macos
  • Risk associated with taking this patch: very low
  • Explanation of risk level: changing signing host only
  • String changes made/needed: No
  • Is Android affected?: no

firefox-esr128 Uplift Approval Request

  • User impact if declined: Eventually we won't be able to sign
  • Code covered by automated testing: no
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: Make sure the browser launches in macos
  • Risk associated with taking this patch: very low
  • Explanation of risk level: changing signing host only
  • String changes made/needed: No
  • Is Android affected?: no

firefox-esr115 Uplift Approval Request

  • User impact if declined: Eventually we won't be able to sign
  • Code covered by automated testing: no
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: Make sure the browser launches in macos
  • Risk associated with taking this patch: very low
  • Explanation of risk level: changing signing host only
  • String changes made/needed: No
  • Is Android affected?: no
Attachment #9499577 - Attachment description: Bug 1968561 - Switch Mac signing to new M2 Mac Signer pool r?#releng → Bug 1968561 - Switch Mac signing to new M2 Mac Signer pool r=#releng-reviewers,ahal
Attachment #9499575 - Flags: approval-mozilla-esr140? → approval-mozilla-esr140+
QA Whiteboard: [uplift][qa-ver-needed-c142/b141]
Attachment #9499576 - Attachment description: Bug 1968561 - Switch Mac signing to new M2 Mac Signer pool r?#releng → Bug 1968561 - Switch Mac signing to new M2 Mac Signer pool r=#release-managers
Attachment #9499577 - Flags: approval-mozilla-esr115? → approval-mozilla-esr115+
Attachment #9499576 - Flags: approval-mozilla-esr128? → approval-mozilla-esr128+

Hello! I have verified that Firefox 142.0a1 (2025-07-10), 141.0b8, 140.1.0esr (20250711093849), 128.13.0esr (from comment 18), and 115.26.0esr (from comment 17) open correctly on macOS 14 (M1 Pro, AArch64) and macOS 12 (Intel).

Note (this is only for treeherder builds):

  • for 140.1.0esr (20250711093849), 128.13.0esr and 115.26.0esr on macOS 14 aarch I have used the treeherder builds from macOS AArch64 Shippable > Bpgo > B > target.dmg (e.g link) and I had to use xattr -cr /Apppath command because the builds were damaged and could not be opened.
  • for 140.1.0esr (20250711093849), 128.13.0esr and 115.26.0esr on macOS 12 Intel, I have used the treeherder builds from macOS Shippable > Bpgo > B > target.dmg` (e.g. link)- here I didn't have to use the above command, but I had to open the Firefox app using double click first and then using r-click -> Open on the Firefox.app.

I will reverify 140.1.0esr, 128.13.0esr and 115.26.0esr with official builds again when they are available. Is the above verification enough, and are the Treeherder builds used correct? Do we also need to verify this on an M2 hardware? Thank you in advance!

Flags: needinfo?(hneiva)

(In reply to Alexandru Trif, Desktop Test Engineering [:atrif] from comment #19)

Note (this is only for treeherder builds):

  • for 140.1.0esr (20250711093849), 128.13.0esr and 115.26.0esr on macOS 14 aarch I have used the treeherder builds from macOS AArch64 Shippable > Bpgo > B > target.dmg (e.g link) and I had to use xattr -cr /Apppath command because the builds were damaged and could not be opened.
  • for 140.1.0esr (20250711093849), 128.13.0esr and 115.26.0esr on macOS 12 Intel, I have used the treeherder builds from macOS Shippable > Bpgo > B > target.dmg` (e.g. link)- here I didn't have to use the above command, but I had to open the Firefox app using double click first and then using r-click -> Open on the Firefox.app.

These are unsigned, I believe you should use macOS Shippable > Rpk instead (for both intel and aarch64).

(In reply to Julien Cristau [:jcristau] from comment #20)

These are unsigned, I believe you should use macOS Shippable > Rpk instead (for both intel and aarch64).

Thank you, Julien, for your answer. I have also verified that the 140.1.0esr (20250711093849), 128.13.0esr, and 115.26.0esr treeherder builds are correctly opened using macOS Shippable > Rpk on both Intel macOS 12 and aarch macOS 14 on M1 Pro.

Thank you :atrif and :jcristau for helping verify this change!

Flags: needinfo?(hneiva)

No worries! Verified fixed with official builds: Firefox 141.0 (20250714153642), 141.1.0esr (20250714132824), 128.13.0esr (20250714124554), and 115.26.0esr (20250714124644). The .dmg and .pkg builds are correctly opened on macOS 12.7 Intel and macOS 14.7.1 aarch on Apple M1 Pro.

Status: RESOLVED → VERIFIED
QA Whiteboard: [uplift][qa-ver-needed-c142/b141] → [uplift][qa-ver-done-c142/b141]
Regressions: 2020988
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: