1968569 - perma fail ubuntu 24.04 uriloader/exthandler/tests/mochitest browser_save_filenames.js | browser_standalone_application_chooser_window_fallback.js

Status: RESOLVED FIXED

(Firefox :: File Handling, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

when running tests in CI on a newer version of linux (18.04 -> 24.04) we run into some new perma failures.

in this debug log, you can see this failure:

[task 2025-05-24T20:32:02.205Z] 20:32:02     INFO - TEST-UNEXPECTED-FAIL | uriloader/exthandler/tests/mochitest/browser_save_filenames.js | attachmentlink61 with spaces.png was saved with the correct name when opened as attachment - Got "webpimage.webp", expected "with spaces.png"
[task 2025-05-24T20:32:02.205Z] 20:32:02     INFO - Stack trace:
[task 2025-05-24T20:32:02.205Z] 20:32:02     INFO - chrome://mochikit/content/browser-test.js:test_is:1654
[task 2025-05-24T20:32:02.205Z] 20:32:02     INFO - chrome://mochitests/content/browser/uriloader/exthandler/tests/mochitest/browser_save_filenames.js:save_links:654
[task 2025-05-24T20:32:02.205Z] 20:32:02     INFO - chrome://mochikit/content/browser-test.js:handleTask:1170
[task 2025-05-24T20:32:02.205Z] 20:32:02     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1242
[task 2025-05-24T20:32:02.205Z] 20:32:02     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1383
[task 2025-05-24T20:32:02.205Z] 20:32:02     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1159
[task 2025-05-24T20:32:02.206Z] 20:32:02     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-05-24T20:32:02.206Z] 20:32:02     INFO - GECKO(23160) | console.error: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFile.isExecutable]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: resource://gre/modules/DownloadIntegration.sys.mjs :: launchDownload :: line 671"  data: no]
[task 2025-05-24T20:32:02.206Z] 20:32:02     INFO - GECKO(23160) | [Parent 23160, Main Thread] WARNING: Set file metadata failed: : 'Error setting file metadata: No such file or directory', file /builds/worker/checkouts/gecko/toolkit/components/downloads/DownloadPlatform.cpp:60
[task 2025-05-24T20:32:02.206Z] 20:32:02     INFO - GECKO(23160) | [Parent 23160, Main Thread] WARNING: The dialog should nullify the dialog progress listener: file /builds/worker/checkouts/gecko/uriloader/exthandler/nsExternalHelperAppService.cpp:2310
[task 2025-05-24T20:32:02.206Z] 20:32:02     INFO - GECKO(23160) | console.log: Downloads: A new download data item was added
[task 2025-05-24T20:32:02.206Z] 20:32:02     INFO - GECKO(23160) | console.log: Downloads: Adding a new DownloadsViewItem to the downloads list. aNewest = true
[task 2025-05-24T20:32:02.206Z] 20:32:02     INFO - GECKO(23160) | console.log: Downloads: Removing a DownloadsViewItem from the downloads list.
[task 2025-05-24T20:32:02.207Z] 20:32:02     INFO - GECKO(23160) | console.log: Downloads: The downloads item count has changed - we are tracking 71 downloads in total.
[task 2025-05-24T20:32:02.207Z] 20:32:02     INFO - GECKO(23160) | console.log: Downloads: Setting the panel's hasdownloads attribute to true.
[task 2025-05-24T20:32:02.209Z] 20:32:02     INFO - GECKO(23160) | console.log: Downloads: Attempting to notify that a new download has started or finished.
[task 2025-05-24T20:32:02.209Z] 20:32:02     INFO - GECKO(23160) | console.log: Downloads: Opening the downloads panel.
[task 2025-05-24T20:32:02.209Z] 20:32:02     INFO - GECKO(23160) | console.log: Downloads: Panel is already showing - focusing instead.
[task 2025-05-24T20:32:02.209Z] 20:32:02     INFO - Download changed!
[task 2025-05-24T20:32:02.210Z] 20:32:02     INFO - GECKO(23160) | console.log: Downloads: Attempting to notify that a new download has started or finished.
[task 2025-05-24T20:32:02.210Z] 20:32:02     INFO - GECKO(23160) | console.log: Downloads: Showing new download notification.
[task 2025-05-24T20:32:02.211Z] 20:32:02     INFO - GECKO(23160) | console.log: Downloads: _updateStateInner, target exists?  /tmp/testsavedir3027217380/with..dots..png true
[task 2025-05-24T20:32:02.211Z] 20:32:02     INFO - Download changed!

and :

[task 2025-05-24T20:34:03.786Z] 20:34:03     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-05-24T20:34:03.786Z] 20:34:03     INFO - Buffered messages logged at 20:32:32
[task 2025-05-24T20:34:03.787Z] 20:34:03     INFO - Entering setup bound test_common_initialize
[task 2025-05-24T20:34:03.787Z] 20:34:03     INFO - Leaving setup bound test_common_initialize
[task 2025-05-24T20:34:03.788Z] 20:34:03     INFO - Entering test bound 
[task 2025-05-24T20:34:03.788Z] 20:34:03     INFO - TEST-PASS | uriloader/exthandler/tests/mochitest/browser_standalone_application_chooser_window_fallback.js | no preferred handler is set - 
[task 2025-05-24T20:34:03.789Z] 20:34:03     INFO - TEST-PASS | uriloader/exthandler/tests/mochitest/browser_standalone_application_chooser_window_fallback.js | no handler registered for ftp - 
[task 2025-05-24T20:34:03.790Z] 20:34:03     INFO - Console message: [JavaScript Warning: "Prevented navigation to “ftp://user:****@domain.com/path” due to an unknown protocol." {file: "https://example.com/browser/uriloader/exthandler/tests/mochitest/FTPprotocolHandler.html" line: 0}]
[task 2025-05-24T20:34:03.790Z] 20:34:03     INFO - Buffered messages finished
[task 2025-05-24T20:34:03.791Z] 20:34:03     INFO - TEST-UNEXPECTED-FAIL | uriloader/exthandler/tests/mochitest/browser_standalone_application_chooser_window_fallback.js | Test timed out - 
[task 2025-05-24T20:34:03.791Z] 20:34:03     INFO - GECKO(31845) | Completed ShutdownLeaks collections in process 31845

this bug will be for tracking investigations, I will be skipping these tests in a manifest in a larger patch to green stuff up.

Comment 1

[Marco Bonardo [:mak]]

Is there a difference in screen resolution, Firefox window size, or dpi that may cause "with spaces" link to go to a new line?
That's what I apparently see in the screenshot.
Then the test ends up clicking on the link in the line above.

Comment 2

[Marco Bonardo [:mak]]

Attachment: screenshot showing link going new line

Comment 3

[:Gijs (out until Jan 5th; he/him)]

needinfo for comment #1 - I think the screen resolution changing can probably affect other tests as well.

We can and probably should make the testcase more resilient to this, but I wanted to highlight this because of the impact on other tests.

Comment 4

[Julien Cristau [:jcristau]]

The screen resolution (https://searchfox.org/mozilla-central/rev/0fe159e3c1a09d9cd22b0ceadbe01efc7e8fd788/taskcluster/scripts/tester/test-linux.sh#186) and dpi (100x100) should be the same. Window size is a possibility.

Comment 5

[:Gijs (out until Jan 5th; he/him)]

Comparing https://firefoxci.taskcluster-artifacts.net/KOh7kU3_QzekaA25mDv5pA/0/public/test_info/mozilla-test-fail-screenshot_d90mfyi7.png and https://firefoxci.taskcluster-artifacts.net/X6U677tKRpe2RrKpfdQ4cA/0/public/test_info/mozilla-test-fail-screenshot_w06hkh_n.png (from a different intermittent failure on 18.04 on the same test) , on 24.04 there is a gnome/gtk (?) launcher "taskbar" thingy on the left of the screen, which wasn't there on 18.04. This means the window size is different, which would explain different wrapping.

Comment 6

[Julien Cristau [:jcristau]]

AFAIK that bar is from the "ubuntu-dock" gnome-shell extension (https://launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock).
Looking at the differences between our 18.04 and 24.04 setups, https://searchfox.org/mozilla-central/rev/f30ba9df8307c48346ac1038be981595bd585603/taskcluster/scripts/tester/test-linux.sh#203 sets GNOME_SHELL_SESSION_MODE=ubuntu on 24.04, but not on 18.04. Which makes the 24.04 case closer to what a "real" stock ubuntu desktop looks like, but different from what we were doing on 18.04.

Comment 7

[Julien Cristau [:jcristau]]

Interestingly even with the dock the test seems to pass on 18.04: https://firefoxci.taskcluster-artifacts.net/YrkAns7mRiWBAsdvilC9YQ/0/public/test_info/video_mochitest-browser-chrome.webm / https://firefoxci.taskcluster-artifacts.net/YrkAns7mRiWBAsdvilC9YQ/0/public/logs/live_backing.log