1968586 - Crash reporter fails to build with --disable-backgroundtasks

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Mathew Hodson]

In file included from Unified_cpp_crashreporter0.cpp:20:
D:/repos/gecko-dev/toolkit/crashreporter/nsExceptionHandler.cpp(1427,7): error: use of undeclared identifier 'BackgroundTasks'
 1427 |   if (BackgroundTasks::IsBackgroundTaskMode()) {
      |       ^
D:/repos/gecko-dev/toolkit/crashreporter/nsExceptionHandler.cpp(1570,36): error: use of undeclared identifier 'BackgroundTasks'
 1570 |   if (doReport && isSafeToDump && !BackgroundTasks::IsBackgroundTaskMode()) {
      |
2 errors generated.

Comment 1

[Mathew Hodson]

Attachment: Bug 1968586 - Fix crash reporter build with --disable-backgroundtasks

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1889462

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gsvelto, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Mathew Hodson]

Can you land this for me?

Comment 5

[Gabriele Svelto [:gsvelto]]

Done

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a9f1df5d4ec1
https://hg.mozilla.org/integration/autoland/rev/8106027a8d37
Fix crash reporter build with --disable-backgroundtasks r=gsvelto

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8106027a8d37

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mathew.hodson, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox141 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Mathew Hodson]

Attachment: Bug 1968586 - Fix crash reporter build with --disable-backgroundtasks

Original Revision: https://phabricator.services.mozilla.com/D251213

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Some downstream distributors could have trouble compiling if they disable background tasks.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: no
• Risk associated with taking this patch: low
• Explanation of risk level: Small patch that doesn't change behaviour in the default configuration.
• String changes made/needed: no
• Is Android affected?: no

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2f2f955bd421
https://hg.mozilla.org/releases/mozilla-beta/rev/e4d7dd8710bb

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR140 when you get a chance.

Comment 13

[Mathew Hodson]

Attachment: Bug 1968586 - Fix crash reporter build with --disable-backgroundtasks

Original Revision: https://phabricator.services.mozilla.com/D251213

Comment 14

[Phabricator Automation]

firefox-esr140 Uplift Approval Request

• User impact if declined: Some downstream distributors could have trouble compiling if they disable background tasks.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: Small patch that doesn't change behaviour in the default configuration.
• String changes made/needed: no
• Is Android affected?: no

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/678f345d2545