1968719 - Make lwtheme-brighttext a proper boolean attribute

Status: RESOLVED FIXED

(WebExtensions :: Themes, task, P5)

Description

[Dão Gottwald [:dao]]

Followup from https://phabricator.services.mozilla.com/D251015#inline-1380899. This is a trivial change, but there are a bunch of tests that need to be updated: https://searchfox.org/mozilla-central/search?q=lwtheme-brighttext&case=true

Comment 1

[Rob Wu [:robwu]]

Sounds reasonable, patches are welcome. The change is basically making the changes as suggested at https://phabricator.services.mozilla.com/D251015#inline-1380899

and updating existing tests that use getAttribute (compared with null or "true") by replacing it with hasAttribute,

and then verifying that the existing tests using hasAttribute still pass.

Comment 2

[Nate Gross]

I'm a new contributor and will submit a patch for this shortly.

Comment 3

[Nate Gross]

Attachment: Bug 1968719 - Made lwtheme-brighttext a proper boolean attribute. r?dao!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b1358223e485
https://hg.mozilla.org/integration/autoland/rev/97016c4c86dd
Made lwtheme-brighttext a proper boolean attribute. r=dao,extension-reviewers,robwu

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/97016c4c86dd