1968724 - Investigate why we can't get correct interactionIds of "enter" simulated click events

Status: RESOLVED FIXED

(Core :: DOM: Performance APIs, defect)

Description

[Nazım Can Altınova [:canova]]

Currently this INP test is failing: testing/web-platform/tests/event-timing/interactionid-keyboard-event-simulated-click-link-enter.html.

It looks like it's something related to how we handle non-pointer id click events that are coming from enter. Previously I worked on this patch to make this work with space button (for the other two wpt tests). But it looks like enter key is not working properly. We need to investigate why and fix it.

Also this is not completely specced yet, here's the spec issue I filed while fixing the other keys: https://github.com/w3c/event-timing/issues/147 Spec author is on board with the idea of adding this to the spec.

Comment 1

[Nazım Can Altınova [:canova]]

Attachment: Bug 1968724 - Assign the last keydown interaction value on keydown instead of keyup r?sefeng

mLastKeydownInteractionValue was initially assigned in keyup instead of
keydown because the spec was initially generating the interactionId of
keydown while we are at keyup, so it was delaying the keydown events.
But since bug 1964426, we don't do this delayed assignment for keydown
events.

So it's a lot easier to implement the correct fix for this after bug 1964426.
Now we simply move this mLastKeydownInteractionValue assignment
to keydown event. Which is the correct location.

Comment 2

[Nazım Can Altınova [:canova]]

Attachment: Bug 1968724 - Assign the last keydown interaction value on keydown instead of keyup r?sefeng

mLastKeydownInteractionValue was initially assigned in keyup instead of
keydown because the spec was initially generating the interactionId of
keydown while we are at keyup, so it was delaying the keydown events.
But since bug 1964426, we don't do this delayed assignment for keydown
events.

So it's a lot easier to implement the correct fix for this after bug 1964426.
Now we simply move this mLastKeydownInteractionValue assignment
to keydown event. Which is the correct location.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/249ae391393b
Assign the last keydown interaction value on keydown instead of keyup r=sefeng

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/249ae391393b