1968789 - Refactor NimbusBranchesController to decouple it from Android dependencies

Status: RESOLVED FIXED

(Firefox for Android :: Tooling, task)

Description

[Mihai Adrian Carare [:mcarare]]

NimbusBranchesController current design encompasses responsibilities beyond the scope of its NimbusBranchesAdapterDelegate interface, creating tight coupling with framework components and application services that are difficult to isolate and mock in a unit testing environment. This over-extension of responsibilities hinders effective testing and makes the controller less maintainable and harder to reason about.

We should refactor it and clearly split responsabilities with it's instantiator, NimbusBranchesFragment

Comment 1

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1968789 - Refactor `NimbusBranchesController` to decouple it from framework dependencies.

This commit refactors NimbusBranchesController to remove its direct dependency on Android Context and NavController
as well as Fenix specific components.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:mcarare, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/33f0278f1e2a
https://hg.mozilla.org/integration/autoland/rev/4321d6cbe6be
Refactor `NimbusBranchesController` to decouple it from framework dependencies. r=android-reviewers,avirvara,jonalmeida

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4321d6cbe6be