1969000 - Rewrite naturalWidth-naturalHeight tests to allow its subtests to be repeated with different conditions

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, task)

Description

[Daniel Holbert [:dholbert]]

These WPTs...
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/html/semantics/embedded-content/the-img-element/naturalWidth-naturalHeight.html
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/html/semantics/embedded-content/the-img-element/naturalWidth-naturalHeight-unavailable.tentative.html
...are currently written with hardcoded <img> elements, where we test their naturalWidth and naturalHeight.

It would be useful to restructure the test so that we can use the same data to test more conditions and more exposed data. For example:

• It'd be nice to be able to repeat the test with srcset="... 2x" (which should cut the naturalWidth/naturalHeight in half)
• It'd be nice to be able to repeat the test and check img.width and img.height (which in many cases are derived from the naturalWidth / naturalHeight).

I'm filing this bug on simply restructuring the test to abstract the actual img elements away into "bundles of data" which then get used to generate img elements, so that later patches can extend the test to generate additional not-quite-duplicate img elements to make these additional checks without having to copypaste all of the source data.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1969000 part 1: Change WPT naturalWidth-naturalHeight.html to append its img elements dynamically with JS. r?#layout

This patch doesn't fundamentally change the behavior or expectations of this
test.

This patch simply moves all of the img elements to a <template> (which is not
rendered), and then appends a clone of those elements to a container within
the body; and then those cloned img elements are what get tested.

This sets the stage for later patches to append additional modified copies of
these img elements, with small modifications (e.g. using 'srcset' rather than
'src').

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1969000: Change WPT naturalWidth-naturalHeight-unavailable.tentative.html to append its img elements dynamically with JS. r?#layout

This patch doesn't fundamentally change the behavior or expectations of this
test.

This patch simply moves all of the img elements to a <template> (which is not
rendered), and then appends a clone of those elements to a container within
the body; and then those cloned img elements are what get tested.

This sets the stage for later patches to append additional modified copies of
these img elements, with small modifications (e.g. using 'srcset' rather than
'src').

Comment 3

[Daniel Holbert [:dholbert]]

While iterating further down in my patch stack, I decided to stop attempting to update/evolve naturalWidth-naturalHeight.html in-place while preserving its faithfulness to the existing and soon-to-be-replaced spec text here.

So I'm abandoning the patch that adjust that test and just keeping the patch that touches the other test (which I intend to expand into the canonical test that tests the new spec text). Sorry for the churn!

Comment 4

[Daniel Holbert [:dholbert]]

(I've decided we should just delete naturalWidth-naturalHeight.html once the spec change is complete, since it'll be obsoleted by the other test which will test the same things [and more] with new expectations; given that, it ended up feeling silly to land these patches to cosmetically adjust it.)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e49384f2c0e0
https://hg.mozilla.org/integration/autoland/rev/f4c23966e101
Change WPT naturalWidth-naturalHeight-unavailable.tentative.html to append its img elements dynamically with JS. r=TYLin

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/52880 for changes under testing/web-platform/tests

Comment 7

[Cristina Horotan [:chorotan]]

Backed out for causing wpt failures at security.pattern.fillStyle.sub.html

Backout link

Push with failures

Failure log

Comment 8

[Daniel Holbert [:dholbert]]

(In reply to Cristina Horotan [:chorotan] from comment #7)

Backed out for causing wpt failures at security.pattern.fillStyle.sub.html

(almost certainly unrelated; sheriffs are looking into it. I'll re-land later on.)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/160097462ef3
https://hg.mozilla.org/integration/autoland/rev/15b8d5a979af
Change WPT naturalWidth-naturalHeight-unavailable.tentative.html to append its img elements dynamically with JS. r=TYLin

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f4c23966e101

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/15b8d5a979af

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Daniel Holbert [:dholbert]]

Attachment: Bug 1969000: Change WPT naturalWidth-naturalHeight-unavailable.tentative.html to append its img elements dynamically with JS. r?#layout

This patch doesn't fundamentally change the behavior or expectations of this
test.

This patch simply moves all of the img elements to a <template> (which is not
rendered), and then appends a clone of those elements to a container within
the body; and then those cloned img elements are what get tested.

This sets the stage for later patches to append additional modified copies of
these img elements, with small modifications (e.g. using 'srcset' rather than
'src').

Original Revision: https://phabricator.services.mozilla.com/D251659

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/04bd312b81a8