1969155 - Send suggest ping over ohttp and add client's country to data

Status: VERIFIED FIXED

(Firefox for Android :: Search, task)

Description

[Amedyne Moya [:amoya]]

Send the glean ping for suggest impressions over OHTTP.

Reference for the desktop changes here: https://phabricator.services.mozilla.com/D250888
Fenix ping: https://dictionary.telemetry.mozilla.org/apps/fenix/pings/fx-suggest

Please uplift these changes to Beta v140, too.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1969155 - part 1 - Send the fx-suggest ping over ohttp r=#android-reviewers

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1969155 - part 2 - Also send the country determining regional search suggestions in the fx-suggest ping r=#android-reviewers

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: bug 1969155 - data review request.txt

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9491478 [details]
bug 1969155 - data review request.txt

No need for the review since we are already collecting this kind of data through Glean's metadata.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64b366ffaca6
part 1 - Send the fx-suggest ping over ohttp r=android-reviewers,Roger
https://hg.mozilla.org/integration/autoland/rev/352fe204efcd
part 2 - Also send the country determining regional search suggestions in the fx-suggest ping r=android-reviewers,Roger,skhan

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/64b366ffaca6
https://hg.mozilla.org/mozilla-central/rev/352fe204efcd

Comment 7

[Petru-Mugurel Lingurar [:petru]]

@QA Please help test using the steps from here that the fx-suggest ping now contains also a country value.

Comment 8

[Mira Lobontiu (Android QA)]

Verified as implemented on the latest Firefox for Android Nightly 141.0a1 from 6/5.
Tested with Samsung galaxy S24 (Android 15) following the steps provided by Petru above.

fx_suggest.ping_type	"fxsuggest-impression"
fx_suggest.iab_category	"22 - Shopping"
fx_suggest.advertiser	"macy's"
fx_suggest.country	"RO"

The Glean dashboard can be seen here.

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9491467 [details]
Bug 1969155 - part 1 - Send the fx-suggest ping over ohttp r=#android-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Need this to increase the usefulness of search suggestions.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Use the steps from here - https://bugzilla.mozilla.org/show_bug.cgi?id=1858542#c6 to verify that the fx-suggest ping now contains also a country value.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small targetted change already verified by QA.
• String changes made/needed:
• Is Android affected?: Yes

Comment 10

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9491468 [details]
Bug 1969155 - part 2 - Also send the country determining regional search suggestions in the fx-suggest ping r=#android-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Need this to increase the usefulness of search suggestions.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Use the steps from here - https://bugzilla.mozilla.org/show_bug.cgi?id=1858542#c6 to confirm that the fx-suggest ping now contains also a country value.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small targetted change already verified by QA.
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9491467 [details]
Bug 1969155 - part 1 - Send the fx-suggest ping over ohttp r=#android-reviewers

Approved for 140.0b6

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9491468 [details]
Bug 1969155 - part 2 - Also send the country determining regional search suggestions in the fx-suggest ping r=#android-reviewers

Approved for 140.0b6

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/fb0974bcd194
https://hg.mozilla.org/releases/mozilla-beta/rev/e1380419c4d7
https://github.com/mozilla-firefox/firefox/commit/c00915984c7b
https://hg.mozilla.org/releases/mozilla-beta/rev/a21507c50848

Comment 14

[Mira Lobontiu (Android QA)]

Verified as fixed on the Firefox for Android Beta 140.0v7 with an Oppo Find N2 Flip (Android 15).
Both fxsuggest-impression and fxsuggest-click pings contain also the country value.