Closed Bug 1969255 Opened 1 year ago Closed 1 year ago

Add support for blocklisting on Windows build versions and monitor refresh rates

Categories

(Core :: Graphics, task)

Desktop
Unspecified
task

Tracking

()

RESOLVED FIXED
141 Branch
Tracking Status
firefox141 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

Details

Attachments

(5 external files)

We should allow blocklisting based on:

  1. A more complete Windows version, UBR if available, otherwise major version and build number, similar to how we block driver versions.
  2. Based on monitor refresh rates, similar to driver versions, as well as if they are mixed.

Telemetry already gets the UBR, so we can use the same method:
https://searchfox.org/mozilla-central/rev/c66e658296cd024ee6ab8330350bfde7c1f05d38/toolkit/components/telemetry/app/TelemetryEnvironment.sys.mjs#2090-2106

We should probably also do something similar for OSX and Android while we are at it to avoid a situation where we need a version range and can't do it.

This is a non-functional change to clean up some of the memory
management in GfxInfo and GfxDriverInfo. This makes it easier to track
what owns what and helps later patches in the stack.

None of these are being actively used in the downloadable blocklist, but
it appears they were never added to the Blocklist.sys.mjs filter
criteria.

Attachment #9491634 - Attachment description: WIP: Bug 1969255 - Part 1. Switch over to managed pointers in GfxInfo. → Bug 1969255 - Part 2. Switch over to managed pointers in GfxInfo.
Attachment #9491635 - Attachment description: WIP: Bug 1969255 - Part 2. Add support for detailed OS version comparison blocklist rules. → Bug 1969255 - Part 3. Add support for detailed OS version comparison blocklist rules.
Attachment #9491636 - Attachment description: WIP: Bug 1969255 - Part 3. Distingush between Windows 10 and 11 in blocklist rules. → Bug 1969255 - Part 4. Distingush between Windows 10 and 11 in blocklist rules.
Attachment #9491637 - Attachment description: WIP: Bug 1969255 - Part 4. Add support for monitor properties to blocklist rules. → Bug 1969255 - Part 5. Add support for monitor properties to blocklist rules.
Blocks: 1969997
Pushed by aosmond@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/2f4298473a13 https://hg.mozilla.org/integration/autoland/rev/5ad3a60b9469 Part 1. Ensure we expose historically missing filter criteria on the blocklist. r=gfx-reviewers,bradwerth https://github.com/mozilla-firefox/firefox/commit/d984fec4f839 https://hg.mozilla.org/integration/autoland/rev/8b9ce5f8f7b8 Part 2. Switch over to managed pointers in GfxInfo. r=geckoview-reviewers,win-reviewers,gfx-reviewers,bradwerth,nalexander,gstoll https://github.com/mozilla-firefox/firefox/commit/e6d94109d2db https://hg.mozilla.org/integration/autoland/rev/7b5c13f0478f Part 3. Add support for detailed OS version comparison blocklist rules. r=geckoview-reviewers,win-reviewers,gfx-reviewers,bradwerth,nalexander,gstoll https://github.com/mozilla-firefox/firefox/commit/f12b5a2e230b https://hg.mozilla.org/integration/autoland/rev/68068c61c001 Part 4. Distingush between Windows 10 and 11 in blocklist rules. r=win-reviewers,gfx-reviewers,bradwerth,gstoll https://github.com/mozilla-firefox/firefox/commit/71c854a7c7c6 https://hg.mozilla.org/integration/autoland/rev/4c158ed62681 Part 5. Add support for monitor properties to blocklist rules. r=geckoview-reviewers,win-reviewers,gfx-reviewers,bradwerth,gstoll
Pushed by pstanciu@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/39a31599c280 https://hg.mozilla.org/integration/autoland/rev/5bea1bf580e0 Revert "Bug 1969255 - Part 5. Add support for monitor properties to blocklist rules. r=geckoview-reviewers,win-reviewers,gfx-reviewers,bradwerth,gstoll" for causing build bustages on gfxConfigManager.cpp
Flags: needinfo?(aosmond)

When I split part 5 into two parts, the other in bug 1969997, I failed to move a removal into the other patch.

Flags: needinfo?(aosmond)
Pushed by aosmond@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c5e3cb59b5d2 https://hg.mozilla.org/integration/autoland/rev/52db9587f6f3 Part 1. Ensure we expose historically missing filter criteria on the blocklist. r=gfx-reviewers,bradwerth https://github.com/mozilla-firefox/firefox/commit/1823b9922713 https://hg.mozilla.org/integration/autoland/rev/9e2616f262d9 Part 2. Switch over to managed pointers in GfxInfo. r=geckoview-reviewers,win-reviewers,gfx-reviewers,bradwerth,nalexander,gstoll https://github.com/mozilla-firefox/firefox/commit/e7a16b3708a2 https://hg.mozilla.org/integration/autoland/rev/96ef791a46f0 Part 3. Add support for detailed OS version comparison blocklist rules. r=geckoview-reviewers,win-reviewers,gfx-reviewers,bradwerth,nalexander,gstoll https://github.com/mozilla-firefox/firefox/commit/67e34e003265 https://hg.mozilla.org/integration/autoland/rev/73d801c22748 Part 4. Distingush between Windows 10 and 11 in blocklist rules. r=win-reviewers,gfx-reviewers,bradwerth,gstoll https://github.com/mozilla-firefox/firefox/commit/ebecd3fbf1b4 https://hg.mozilla.org/integration/autoland/rev/ecfef5dad61f Part 5. Add support for monitor properties to blocklist rules. r=geckoview-reviewers,win-reviewers,gfx-reviewers,bradwerth,gstoll
Pushed by amarc@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/eba25db42af0 https://hg.mozilla.org/integration/autoland/rev/b4515117b946 Revert "Bug 1969255 - Part 5. Add support for monitor properties to blocklist rules. r=geckoview-reviewers,win-reviewers,gfx-reviewers,bradwerth,gstoll" for causing build bustages @ GfxInfo.h

Backed out for causing bustages @ GfxInfo.h

Flags: needinfo?(aosmond)

Did not try building iOS, fixed now after adjusting the function declarations.

Flags: needinfo?(aosmond)
Pushed by aosmond@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ccaa5aaf9575 https://hg.mozilla.org/integration/autoland/rev/15557cdd78b2 Part 1. Ensure we expose historically missing filter criteria on the blocklist. r=gfx-reviewers,bradwerth https://github.com/mozilla-firefox/firefox/commit/0d2c62d0b275 https://hg.mozilla.org/integration/autoland/rev/3fd4addfcaa9 Part 2. Switch over to managed pointers in GfxInfo. r=geckoview-reviewers,win-reviewers,gfx-reviewers,bradwerth,nalexander,gstoll https://github.com/mozilla-firefox/firefox/commit/5cdb3cb68935 https://hg.mozilla.org/integration/autoland/rev/c5e2fec851a9 Part 3. Add support for detailed OS version comparison blocklist rules. r=geckoview-reviewers,win-reviewers,gfx-reviewers,bradwerth,nalexander,gstoll https://github.com/mozilla-firefox/firefox/commit/5e2e6bb5d7d5 https://hg.mozilla.org/integration/autoland/rev/da1d737b597e Part 4. Distingush between Windows 10 and 11 in blocklist rules. r=win-reviewers,gfx-reviewers,bradwerth,gstoll https://github.com/mozilla-firefox/firefox/commit/c159fd652a77 https://hg.mozilla.org/integration/autoland/rev/cea1f4a13557 Part 5. Add support for monitor properties to blocklist rules. r=geckoview-reviewers,win-reviewers,gfx-reviewers,bradwerth,gstoll

whoops double

Assignee: aosmond → nobody
QA Whiteboard: [qa-triage-done-c142/b141]
Assignee: nobody → aosmond
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: