1969308 - Unconvert totalsize metric to standard byte number

Status: VERIFIED FIXED

(Core :: Machine Learning, defect)

Description

[Nick]

the wrong conversion method was used to convert "totalSize".

Comment 1

[Nick]

Attachment: Bug 1969308 - Unconvert totalsize metric to standard byte number r=mardak

the wrong conversion method was used to convert 'totalSize'

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ed45b112efe3
https://hg.mozilla.org/integration/autoland/rev/5e8d586600d7
Unconvert totalsize metric to standard byte number r=Mardak,extension-reviewers

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5e8d586600d7

Comment 4

[Nick]

Attachment: Bug 1969308 - Unconvert totalsize metric to standard byte number r=mardak

the wrong conversion method was used to convert 'totalSize'

Original Revision: https://phabricator.services.mozilla.com/D251744

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: model size on metrics will be the wrong format
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: initiate actions to trigger glean events. (init a model deletion from about:addons )
• Risk associated with taking this patch: UI errors / metric errors
• Explanation of risk level: This should only touch metrics so I beleive risk is low.
• String changes made/needed: n/a
• Is Android affected?: no

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/f801325ca1cb
https://hg.mozilla.org/releases/mozilla-beta/rev/b9e56b774e8a

Comment 7

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (141.0a1/20250603213222) and Beta (140.0b5
/20250603182419 from https://treeherder.mozilla.org/jobs?repo=mozilla-beta&revision=b9e56b774e8a34db6fbf6f3c419b59ca182349a8) under Windows 11 and Ubuntu 24.04 LTS.

When initiating a model deletion from about:addons, the corresponding glean event shows model size as "size": "23685047" on the latest Nightly and patched Beta 140.0b5, as opposed to the unpatched Beta 140.0b4 which shows "size": "22.6 MB", confirming the fix.