1969475 - Support dividers in moz-select

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement)

Description

[Mark Striemer [:mstriemer]]

In some places there may be groups of items in a select. This can be accomplished by putting an <hr> in a regular select, but currently moz-select does not support copying those over into its inner select instance.

Acceptance criteria:

<moz-select>
  <moz-option label="Item 1"></moz-option>
  <hr>
  <moz-option label="Item 2"></moz-option>
</moz-select>

Renders two items with a divider between them

Comment 1

[Mark Kennedy [:mark]]

Attachment: Bug 1969475 - Update moz-select to support menu separators for Applications section r=#reusable-components-reviewers-rotation

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8d4e4eef1454
https://hg.mozilla.org/integration/autoland/rev/a70486ab3d9f
Update moz-select to support menu separators for Applications section r=hjones

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/589ab18cff40
https://hg.mozilla.org/integration/autoland/rev/17f8b152b2ac
Revert "Bug 1969475 - Update moz-select to support menu separators for Applications section r=hjones" for causing bc failures @browser_multiselect_tabs_reorder.js.

Comment 4

[agoloman]

Backed out for causing bc failures @browser_multiselect_tabs_reorder.js.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/60cb05e911a1
https://hg.mozilla.org/integration/autoland/rev/82e7ad37ba58
Update moz-select to support menu separators for Applications section r=hjones

Comment 6

[agoloman]

Relanded because it was not the actual culprit.

Comment 7

[Mark Striemer [:mstriemer]]

[Tracking Requested - why for this release]: This is needed to provide the separator between Blocked and the chatbot providers on the chatbot provider dropdown in bug 2005799

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/82e7ad37ba58

Comment 9

[Mark Striemer [:mstriemer]]

Attachment: Bug 1969475 - Update moz-select to support menu separators for Applications section

Original Revision: https://phabricator.services.mozilla.com/D278863

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/15e4c8588d6d
https://hg.mozilla.org/releases/mozilla-beta/rev/a5873c2fa5e4