1969492 - Add picture-in-picture support to GVE

Status: NEW

(GeckoView :: General, enhancement)

Description

[Jonathan Almeida [:jonalmeida]]

This would implement Android PiP mode and connect the new onPipModeChanged API. It would be helpful for the webcompat team to be able to test WebCompat interventions in GVE where they already do the rest of the testing.

In Android Components (AC; the code layer that consumes GeckoView), we have an implementation of picture-in-picture that is used across Fenix, Focus, and Reference Browser. This works well for us in most cases.

Another important GeckoView consumer is GeckoView Example (GVE) that cannot make use of the PictureInPictureFeature so we would have to upstream the logic from AC into GVE so that we enable the system feature and notify the GeckoSession.onPipModeChanged.

---

For this work, it would be good to look at how PiP is implemented in Reference Browser (least complex implementation), identify the equivalent APIs (e.g. choosing the selected GeckoSession is different in Fenix/Focus), and pick out the most important parts that are needed to enable PiP in GVE.

Comment 1

[Jonathan Almeida [:jonalmeida]]

Adding ohall and myself as mentors instead after speaking about it offline. It might be a good bug for any new hires.

Comment 2

[Thomas Wisniewski [:twisniewski]]

Note that for the purposes of our automated testing, we also need a way to trigger PiP in webdriver. This was done in bug 1959470 for Fenix by adding ChromeUtils.androidMoveTaskToBack().