Closed Bug 1969501 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 52873 - [gap-decorations] Mark GapDecorations flag as experimental

Categories

(Core :: Layout: Columns, task, P4)

Product:
Core
Component:
Layout: Columns
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
141 Branch
Tracking Flags:
Tracking Status
firefox141 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Attachments

(2 files)

Bug 1969501 [wpt PR 52873] - [gap-decorations] Mark GapDecorations flag as experimental, a=testonly
48 bytes, text/x-phabricator-request
Details | Review
Bug 1969501 [wpt PR 52873] - Update wpt metadata, a=testonly
48 bytes, text/x-phabricator-request
Details | Review

Sync web-platform-tests PR 52873 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/52873
Details from upstream follow.

Javier Contreras Tenorio (from Dev Box) <javiercon@microsoft.com> wrote:

[gap-decorations] Mark GapDecorations flag as experimental

This CL marks the GapDecorations feature flag as experimental, in order
for us to have dev trials on the feature, and we fix test expectation
files accordingly. List of non-obvious fixes:

  • computed_style_test.cc: This had to be updated to now take into account that
    ColumnRuleWidth is now a CSSValueList, so we keep the spirit of the
    test, we just make sure to special case the new types.

*flexbox-columns: this test was deleted in this CL because it is testing
that there are no column rules in a flexbox container, which is not true
now with GapDecorations, so the test no longer makes sense.

  • column-height-009-ref: as discussed and resolved here
    https://github.com/w3c/csswg-drafts/issues/2309 column rules should be
    drawn to the height of the container

  • column-rule-*-invalid: These are changed because with GapDecorations we do
    accept lists of values.

  • column-rule-*.html: These were changed to account for the fact that these
    rules we no longer treat as CSSKeywordValue and instead are now
    CSSStyleValues. With GapDecorations we fail in the set up since now
    ruleWidth is a CSSStyleValue rather than a CSSUnitValue, which makes the
    test fail before we even get to the asserts. All we can test here now is
    whether or not we are a CSSStyleValue. We follow the example of other
    properties that are of this type too.

  • column-rule invalidation tests rebaseline: the invalidation rect is
    bigger now with gap decorations enabled.

  • Lastly, we have added interpolation/animation tests as failing to the
    test expectations to account for the fact that this does not yet work
    with gap decorations. We are aware of this, but we wanted to get the
    feature out for dev trials as soon as possible. We have made a tracking
    bug for this.

Bug: 357648037, 419066541, 420959039, 421053112

Change-Id: Ie1df2c4987f76008dee872e87db7ca65649b8654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6514569
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Kevin Babbitt \<kbabbitt@microsoft.com>
Reviewed-by: Alison Maher \<almaher@microsoft.com>
Reviewed-by: Sam Davis Omekara \<samomekarajr@microsoft.com>
Commit-Queue: Javier Contreras \<javiercon@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1467585}

Component: web-platform-tests → Layout: Columns
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 4 subtests

Status Summary

Firefox

OK : 3
PASS : 7
FAIL : 1
ERROR: 2

Chrome

OK : 5
PASS : 65
FAIL : 25

Safari

OK : 5
PASS : 65
FAIL : 25

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /css/css-typed-om/the-stylepropertymap/properties/column-rule-style.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
  • /css/css-typed-om/the-stylepropertymap/properties/column-rule-width.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

  • /css/css-typed-om/the-stylepropertymap/properties/column-rule-style.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: OK)
  • /css/css-typed-om/the-stylepropertymap/properties/column-rule-width.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] (Chrome: OK, Safari: OK)

Automatic update from web-platform-tests
[gap-decorations] Mark GapDecorations flag as experimental

This CL marks the GapDecorations feature flag as experimental, in order
for us to have dev trials on the feature, and we fix test expectation
files accordingly. List of non-obvious fixes:

  • computed_style_test.cc: This had to be updated to now take into account that
    ColumnRuleWidth is now a CSSValueList, so we keep the spirit of the
    test, we just make sure to special case the new types.

*flexbox-columns: this test was deleted in this CL because it is testing
that there are no column rules in a flexbox container, which is not true
now with GapDecorations, so the test no longer makes sense.

  • column-height-009-ref: as discussed and resolved here
    https://github.com/w3c/csswg-drafts/issues/2309 column rules should be
    drawn to the height of the container

  • column-rule-*-invalid: These are changed because with GapDecorations we do
    accept lists of values.

  • column-rule-*.html: These were changed to account for the fact that these
    rules we no longer treat as CSSKeywordValue and instead are now
    CSSStyleValues. With GapDecorations we fail in the set up since now
    ruleWidth is a CSSStyleValue rather than a CSSUnitValue, which makes the
    test fail before we even get to the asserts. All we can test here now is
    whether or not we are a CSSStyleValue. We follow the example of other
    properties that are of this type too.

  • column-rule invalidation tests rebaseline: the invalidation rect is
    bigger now with gap decorations enabled.

  • Lastly, we have added interpolation/animation tests as failing to the
    test expectations to account for the fact that this does not yet work
    with gap decorations. We are aware of this, but we wanted to get the
    feature out for dev trials as soon as possible. We have made a tracking
    bug for this.

Bug: 357648037, 419066541, 420959039, 421053112

Change-Id: Ie1df2c4987f76008dee872e87db7ca65649b8654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6514569
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Sam Davis Omekara <samomekarajr@microsoft.com>
Commit-Queue: Javier Contreras <javiercon@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1467585}

--

wpt-commits: 8f937883af326007f0711a245de8d9039d74d548
wpt-pr: 52873

https://hg.mozilla.org/mozilla-central/rev/c94946c6255f
https://hg.mozilla.org/mozilla-central/rev/590b6cae2436

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox141: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 141 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: